Update master/linkextractor.rb for live logs. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Travis Hunt <[email protected]>
|
FYI - PWD already merged my other pull request... PR#238 so instructions will be incorrect until this is merged. Only impact is the |
|
@ibnesayeed would you like to review this small PR? :) It will take just a minute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature pull request to update the linkextractor.rb to handle the extraction.log file so that the log can be viewed and followed while the container is running. Sending PR to PWD repository as well.
PR for Step6 branch: #13
When running through the tutorial, I was confused why the logs weren't showing anything while submitting different URLs for extraction.