-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Chronos in TSFM Inference Service #203
Support Chronos in TSFM Inference Service #203
Conversation
Signed-off-by: Giridhar Ganapavarapu <[email protected]>
…e_abstraction_chronos merge upstream/service_abstractions
@gganapavarapu let's redirect the target branch to https://github.com/ibm-granite/granite-tsfm/tree/services_chronos_support |
@gganapavarapu have you run |
Yes, I have run it. It is not reverting some of the style changes. |
services/inference/tsfm_config.json
Outdated
"service_handler_module_path": "tsfminference.chronos_service_handler", | ||
"service_handler_class_name": "ChronosForecastingHandler", | ||
"maximum_prediction_length": 64, | ||
"minimum_context_length": 256, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these parameters correct? Does chronos have min/max context?
@wgifford any insight into why the tests are not kicking off on this PR? |
It seems I need to approve the workflow actions under Actions tab. That triggered the approval request from maintainers. |
Updated the PR to enable only |
@gganapavarapu please see: |
@gganapavarapu please run poetry lock on a new clone of your repo from a linux machine and push changes. it's sometimes hard to resolve this issue via merging. |
I don't have a linux machine at the moment. Let me try to get one. If this something you can run quickly, it will greatly help! |
Tough for me because I can only affect change on your branch for a PR process which I tried this morning and that doesn't seem to be working. |
@gganapavarapu if you add me (my gmail address which I'll ping you separately) as a collaborator to your fork then I think I could do it more easily. |
@gganapavarapu it'd probably be okay to run from your mac as long as you did a |
I have seen mac related files generated in poetry.lock like below and so, did not push it.
|
fix notebook formatting issues
@gganapavarapu at least now we're down to actual code errors :-). |
…o service_abstraction_chronos merge with local
Thank you @ssiegel95 |
Updated target branch to |
@gganapavarapu I keep trying to resolve this but it doesn't stick. We want to go with
|
Signed-off-by: Giridhar Ganapavarapu <[email protected]>
b9f2aa5
into
ibm-granite:new_model_integrations
This PR is to enable Chronos in TSFM inference service.