Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added branch selection when deploying, closes #26 #28

Merged
merged 9 commits into from
Sep 15, 2016
Merged

Conversation

reicruz
Copy link
Contributor

@reicruz reicruz commented Sep 15, 2016

You can now specify a branch when deploying a project:

  • Requests branches from repo and lists them for the user to pick
  • If only one branch exists, automatically deploy it
  • If error with request (rate limit reached) check for user provided HUBOT_GITHUB_TOKEN
  • If token not provided or another error with the request, user is prompted to manually enter branch

Note: Tests are updated to cover the changes but not using the new testing guidelines established in CONTRIBUTING.md. Currently working on a different PR for updating the tests to use portend. #24

@aeweidne assigned to you since you initially worked on this module.

Copy link
Contributor

@aeweidne aeweidne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aeweidne aeweidne merged commit ce57844 into master Sep 15, 2016
@aeweidne aeweidne deleted the issues/26 branch September 15, 2016 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants