Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql): don't fuse subsequent filter operations #9064

Closed
wants to merge 1 commit into from
Closed

fix(sql): don't fuse subsequent filter operations #9064

wants to merge 1 commit into from

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Apr 26, 2024 •
edited
Loading

"fixes" #9058

@cpcloud
Copy link
Member

cpcloud commented Apr 26, 2024

Why not disable all merging to avoid unforeseen problems?

@kszucs
Copy link
Member Author

kszucs commented Apr 26, 2024 •
edited
Loading

I am not entirely agreeing with this change, see my comment #9058 (comment)

@kszucs kszucs mentioned this pull request Apr 26, 2024
Merged
@kszucs
Copy link
Member Author

kszucs commented Apr 26, 2024

Closing in favor of #9065

@kszucs kszucs closed this Apr 26, 2024
cpcloud pushed a commit that referenced this pull request Apr 30, 2024
@kszucs
feat(sql): add option to enable/disable select merging (#9065)
4bc9314 
Add a global option to enable or disable merging select statements where
possible. This can serve as an escape route if the optimization fails.
It is currently enabled by default, we may change to make it opt-in.

xref #9064 and #9058

Closes #9058.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kszucs @cpcloud