[PHPStan] Aligned baseline after PHPStan update

[alongosz]

🎫 Issue	n/a

Description:

Seems PHPStan now analyses sanity of code relying on preg_match $matches possible results.

After reviewing it a bit, I see that there's definitely a potential for improvements and there might be even some bugs.

However doing it now to fix CI is too risky and requires QA. Therefore, after talking to @Steveb-p, I created IBX-8919 for further consideration.

PHPStan failures:

 ------ ------------------------------------------------------------------------------------------------------- 
  Line   src/lib/FieldType/RichText/RichTextStorage.php                                                         
 ------ ------------------------------------------------------------------------------------------------------- 
  78     Offset 2 does not exist on array{0?: string, 1?: ''|'ezremote://', 2?: string, 3?: non-empty-string}.  
  80     Offset 2 does not exist on array{0?: string, 1: 'ezremote://', 2?: string, 3?: non-empty-string}.      
  89     Offset 1 does not exist on array{0?: string, 1?: ''|'ezremote://', 2?: string, 3?: non-empty-string}.  
  89     Offset 2 does not exist on array{0?: string, 1?: ''|'ezremote://', 2?: string, 3?: non-empty-string}.  
  89     Offset 3 does not exist on array{0?: string, 1?: ''|'ezremote://', 2?: string, 3?: non-empty-string}.  
  171    Offset 1 does not exist on array{0?: string, 1?: string, 2?: non-empty-string}.                        
  171    Offset 2 does not exist on array{0?: string, 1?: string, 2?: non-empty-string}.                        
 ------ -------------------------------------------------------------------------------------------------------  ------ --------------------------------------------------------------------------------------------- 
  Line   src/lib/RichText/Converter/Link.php                                                          
 ------ --------------------------------------------------------------------------------------------- 
  82     Offset 1 does not exist on array{0?: string, 1?: string, 2?: string, 3?: non-empty-string}.  
  82     Offset 2 does not exist on array{0?: string, 1?: string, 2?: string, 3?: non-empty-string}.  
  82     Offset 3 does not exist on array{0?: string, 1?: string, 2?: string, 3?: non-empty-string}.  
 ------ ---------------------------------------------------------------------------------------------  ------ ----------------------------------------------------------------------------------------- 
  Line   src/lib/RichText/Converter/Render/Embed.php                                              
 ------ ----------------------------------------------------------------------------------------- 
  86     Offset 1 does not exist on array{0?: string, 1?: non-empty-string, 2?: numeric-string}.  
  87     Offset 2 does not exist on array{0?: string, 1: 'ezcontent', 2?: numeric-string}.        
  97     Offset 2 does not exist on array{0?: string, 1: 'ezlocation', 2?: numeric-string}.       
 ------ -----------------------------------------------------------------------------------------  ------ ------------------------------------------------------------------------------------------------------- 
  Line   src/lib/RichText/RelationProcessor.php                                                                 
 ------ ------------------------------------------------------------------------------------------------------- 
  76     Offset 1 does not exist on array{0?: string, 1?: non-empty-string, 2?: string, 3?: non-empty-string}.  
  76     Offset 2 does not exist on array{0?: string, 1?: non-empty-string, 2?: string, 3?: non-empty-string}.  
 ------ -------------------------------------------------------------------------------------------------------  ------ ------------------------------------------------------------------------------------------------------- 
  Line   src/lib/RichText/Validator/InternalLinkValidator.php                                                   
 ------ ------------------------------------------------------------------------------------------------------- 
  67     Offset 1 does not exist on array{0?: string, 1?: non-empty-string, 2?: string, 3?: non-empty-string}.  
  67     Offset 2 does not exist on array{0?: string, 1?: non-empty-string, 2?: string, 3?: non-empty-string}.  
 ------ -------------------------------------------------------------------------------------------------------

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[adamwojs]

You can merge it up @alongosz