Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translation extractor for custom tags #162

Merged
merged 8 commits into from
Jun 4, 2024

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented May 28, 2024

🎫 Issue N/A

Description:

Added missing translation for custom tags.

For QA:

Verify custom tags & custom styles labels

image

image

Documentation:

Microcopy review is needed.

@adamwojs adamwojs marked this pull request as ready for review May 28, 2024 07:42
@adamwojs adamwojs requested review from mikadamczyk, a team and juskora May 28, 2024 07:43
@konradoboza konradoboza requested a review from a team May 28, 2024 07:48
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz
Copy link
Member

@adamwojs I've merged #163 and pushed one minor fix aligning missing class property change after DIC changes. CI should be ok now.

@alongosz alongosz requested a review from mikadamczyk May 28, 2024 10:53
@adamwojs
Copy link
Member Author

@adamwojs I've merged #163 and pushed one minor fix aligning missing class property change after DIC changes. CI should be ok now.

Thank you very much @alongosz 🙇‍♂️

@lserwatka
Copy link
Contributor

Thank you all for handling this. Great team effort!

@juskora
Copy link

juskora commented Jun 4, 2024

QA Approved on Ibexa DXP Commerce 4.6-dev.

@adamwojs adamwojs merged commit b1ec1be into 4.6 Jun 4, 2024
21 checks passed
@adamwojs adamwojs deleted the fixed_custom_tag_translations branch June 4, 2024 10:12
@alongosz alongosz mentioned this pull request Sep 17, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants