Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8121: Fixed code style for 5.0 #160

Merged
merged 3 commits into from
May 7, 2024
Merged

IBX-8121: Fixed code style for 5.0 #160

merged 3 commits into from
May 7, 2024

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Apr 26, 2024 •
edited
Loading

🎫 Issue IBX-8121

Description:

This PR fixes code style issues for Ibexa DXP 5.0.

Note

052da0f contains PHPStan fixes.

@Steveb-p Steveb-p requested a review from a team April 26, 2024 08:57
@konradoboza konradoboza requested a review from a team April 26, 2024 09:00
alongosz
alongosz reviewed May 6, 2024
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Steveb-p I'm assuming the version of PHP used by browser tests and causing them to fail cannot be fixed here?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
20.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Steveb-p
Copy link
Contributor Author

Steveb-p commented May 7, 2024

@Steveb-p I'm assuming the version of PHP used by browser tests and causing them to fail cannot be fixed here?

I've changed the image used for browser-tests workflow in e5435d6.

@Steveb-p Steveb-p merged commit 8568d2e into main May 7, 2024
14 of 15 checks passed
@Steveb-p Steveb-p deleted the ibx-8121/fix-5.0-code-style branch May 7, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@alongosz alongosz

@konradoboza konradoboza

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Steveb-p @alongosz @konradoboza