Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6400: Moving images between lines can result in a disapperance of another image #132

Merged
merged 1 commit into from
Oct 6, 2023
Merged

IBX-6400: Moving images between lines can result in a disapperance of another image #132

merged 1 commit into from
Oct 6, 2023

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-6400
Bug/Improvement bg
New feature no
Target version 4.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@GrabowskiM GrabowskiM changed the base branch from main to 4.5 October 5, 2023 06:57
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tomaszszopinski
tomaszszopinski approved these changes Oct 6, 2023
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.5 commerce.

@dew326 dew326 merged commit 72f17e1 into 4.5 Oct 6, 2023
22 of 23 checks passed
@dew326 dew326 deleted the IBX-6400-move-image-undefined branch October 6, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

Assignees

@alongosz alongosz

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GrabowskiM @dew326 @Gengar-i @tomaszszopinski @alongosz