Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed LiteralLayoutNestedListTest namespace #131

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Oct 4, 2023

Question Answer
JIRA issue -
Bug/Improvement yes
New feature no
Target version 4.5+
BC breaks no
Tests pass yes
Doc needed no

Moved LiteralLayoutNestedListTest from Ibexa\Tests\FieldTypeRichText\Richtext\Converter to Ibexa\Tests\FieldTypeRichText\RichText\Converter in order to fix the following warning reporeted durning product installation:

Class Ibexa\Tests\FieldTypeRichText\RichText\Converter\LiteralLayoutNestedListTest located in ./vendor/ibexa/fieldtype-richtext/tests/lib/Richtext/Converter/LiteralLayoutNestedListTest.php does not comply with psr-4 autoloading standard. Skipping.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs requested a review from a team October 4, 2023 06:23
@adamwojs adamwojs merged commit db6a959 into 4.5 Oct 4, 2023
27 checks passed
@adamwojs adamwojs deleted the fixed_invalid_ns_v45 branch October 4, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants