IBX-8363: Corrected namespace for RichTextFieldValueConverterTest and…

… added return types
ibexa · Jun 5, 2024 · e1353b2 · e1353b2
1 parent b1ec1be
commit e1353b2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -2038,16 +2038,6 @@ parameters:
 			count: 1
 			path: tests/lib/Form/DataTransformer/RichTextTransformerTest.php
 
-		-
-			message: "#^Method Ibexa\\\\FieldTypeRichText\\\\Persistence\\\\Legacy\\\\Tests\\\\Content\\\\FieldValue\\\\Converter\\\\RichTextFieldValueConverterTest\\:\\:testToFieldValue\\(\\) has no return type specified\\.$#"
-			count: 1
-			path: tests/lib/Persistence/Legacy/Tests/Content/FieldValue/Converter/RichTextFieldValueConverterTest.php
-
-		-
-			message: "#^Method Ibexa\\\\FieldTypeRichText\\\\Persistence\\\\Legacy\\\\Tests\\\\Content\\\\FieldValue\\\\Converter\\\\RichTextFieldValueConverterTest\\:\\:testToStorageValue\\(\\) has no return type specified\\.$#"
-			count: 1
-			path: tests/lib/Persistence/Legacy/Tests/Content/FieldValue/Converter/RichTextFieldValueConverterTest.php
-
 		-
 			message: "#^Call to method expects\\(\\) on an unknown class Ibexa\\\\FieldTypeRichText\\\\RichText\\\\Converter\\.$#"
 			count: 1

diff --git a/...Persistence/Legacy/Tests/Content/FieldValue/Converter/RichTextFieldValueConverterTest.php b/...Persistence/Legacy/Tests/Content/FieldValue/Converter/RichTextFieldValueConverterTest.php
@@ -6,7 +6,7 @@
  */
 declare(strict_types=1);
 
-namespace Ibexa\FieldTypeRichText\Persistence\Legacy\Tests\Content\FieldValue\Converter;
+namespace Ibexa\Tests\FieldTypeRichText\Persistence\Legacy\Tests\Content\FieldValue\Converter;
 
 use Ibexa\Contracts\Core\Persistence\Content\FieldValue;
 use Ibexa\Core\Persistence\Legacy\Content\StorageFieldValue;
@@ -54,7 +54,7 @@ protected function tearDown(): void
     /**
      * @covers \Ibexa\FieldTypeRichText\Persistence\Legacy\RichTextFieldValueConverter::toStorageValue
      */
-    public function testToStorageValue()
+    public function testToStorageValue(): void
     {
         $value = new FieldValue();
         $value->data = $this->docbookString;
@@ -67,7 +67,7 @@ public function testToStorageValue()
     /**
      * @covers \Ibexa\FieldTypeRichText\Persistence\Legacy\RichTextFieldValueConverter::toFieldValue
      */
-    public function testToFieldValue()
+    public function testToFieldValue(): void
     {
         $storageFieldValue = new StorageFieldValue();
         $storageFieldValue->dataText = $this->docbookString;