Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8470: Upgraded codebase to Symfony 6 #19

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Nov 19, 2024

Caution

This is a part of bigger set of changes, to be merged together when ready

  • Remove TMP commits before merge
🎫 Issue IBX-8470

Related PRs:

Description:

This PR bumps Symfony to v6 with some codebase upgrades.
Additionally I saw we still use SiteAccess as a service and inject it. Replaced it with SiteAccessServiceInterface.
No test coverage, nor PHPStan to check if this works...

Key changes:

  • [Git] Added missing contracts and lib directories
  • [Git] Added tests directory
  • Bumped Symfony packages requirements to ^6.4
  • Improved code of related Symfony bundle extension points
  • Dropped obsolete ezplatform:cron:run command alias
  • Improved codebase quality
  • Injected SiteAccessServiceInterface into CronJobsRegistry
  • [Git] Updated PHP CS Fixer cache .gitignore entry

QA:

Sanities in the form of regression tests.

Documentation:

No documentation required.

Copy link

sonarcloud bot commented Nov 19, 2024

@alongosz alongosz marked this pull request as ready for review November 19, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant