-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance PHPDoc #463
base: 4.6
Are you sure you want to change the base?
Enhance PHPDoc #463
Conversation
Don't use advanced format in summary, it won't be rendered.
Don't use advanced format in summary, it won't be rendered. Define array key type, or it will be rendered as array<string|int, …> phpDocumentor don't seem to understand self.
@@ -53,12 +55,12 @@ class DateMetadata extends Criterion implements TrashCriterion, FilteringCriteri | |||
]; | |||
|
|||
/** | |||
* Creates a new DateMetadata criterion on $metadata. | |||
* Creates a new DateMetadata criterion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find such property in the contracts namespace. (I may haven't look well enough in the namespace.) It might not be in this contracts namespace, and hidden by abstraction. If no link can be made to it, it probably don't worth being mentioned.
One docblock per constant.
Quality Gate passedIssues Measures |
Description:
array<string|int,
rendering.<code>
rendered as a single line.self
to have a link (to the current page, debatable, it could also be$this
).Previews:
Ibexa\Contracts\Core\FieldType\Generic\ValidationError\ConstraintViolationAdapter
@see
tags in its introduction and<meta name="description"
.Ibexa\Contracts\Core\Limitation\Target\Builder\VersionBuilder
@see
tags in its introduction.Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion::getSpecifications()
Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\DateMetadata
DateMetadata::TRASHED
toTrashService::findTrashItems()
Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\UserMetadata
Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\Operator\Specifications
Criterion::getSpecifications()
is added.Ibexa\Contracts\Core\Search\Capable
@see
in its summary.For QA:
Documentation: