Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch '1.3' of ezsystems/ezplatform-kernel into 4.6 #369

Merged
merged 2 commits into from
May 29, 2024

Conversation

ezrobot
Copy link

@ezrobot ezrobot commented May 10, 2024

…nges

For more details see https://issues.ibexa.co/browse/IBX-5388 and ezsystems/ezplatform-kernel#397

Key changes:

* Fixed performance issues of content updates after field definition changes

* Made DefaultDataFieldStorage extend FieldStorage

* [Tests] Aligned test coverage with the changes

---------

Co-Authored-By: Paweł Niedzielski <[email protected]>
Co-Authored-By: Andrew Longosz <[email protected]>
@alongosz
Copy link
Member

@Nattfarinn PHPStan CI has been fixed on 4.6, so here it should pass now :)

@micszo
Copy link
Contributor

micszo commented May 15, 2024

FYI, during retests general problem with image editor and image asset was found https://issues.ibexa.co/browse/IBX-8298. It covers the flow which was important on 3.3 for these changes (ezsystems/ezplatform-kernel#397 (review)).

Update: Patch from https://github.com/spatie/image-optimizer/pull/219/files resolves the above issue. ❤️

Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not find issues during retests.

QA Approved on Ibexa Commerce 4.6.7-dev.

Only fixing CI remains.

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpstan-baseline.neon Show resolved Hide resolved
phpstan-baseline.neon Outdated Show resolved Hide resolved
@Nattfarinn Nattfarinn requested a review from alongosz May 29, 2024 09:36
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit 25100f0 into 4.6 May 29, 2024
20 checks passed
@alongosz alongosz deleted the temp_1.3_to_4.6 branch May 29, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants