Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not prepend siteaccess to URL if default #352

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pspanja
Copy link
Contributor

@pspanja pspanja commented Apr 9, 2024

🎫 Issue IBX-8088

Description:

If default siteaccess uses URI type matching, URL alias generated by passing default siteaccess explicitly will be different than when generated without passing it explicitly. Since in both cases the URL alias is generated for the same siteaccess, the result should be the same:

Example:

{{ path('ibexa.url.alias', {'contentId': content.id, 'siteaccess': 'default'}) }}

generates:

/default/some-alias

But:

{{ path('ibexa.url.alias', {'contentId': content.id}) }}

generates:

/some-alias

This adds the check that the matched siteaccess is default, in which case prepending of the siteaccess ID to the URL is skipped.

For QA:

Documentation:

@pspanja pspanja force-pushed the default_siteaccess_uri branch from 2822bcc to f8e939b Compare April 9, 2024 08:36
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants