Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6636: ezSelection default label 'ALL' is incorrect for NOT multiple choice setting #76

Open
wants to merge 1 commit into
base: 4.6
Choose a base branch
from
Open

IBX-6636: ezSelection default label 'ALL' is incorrect for NOT multiple choice setting #76

wants to merge 1 commit into from

Conversation

vidarl
Copy link

@vidarl vidarl commented Nov 13, 2024 •
edited
Loading

🎫 Issue IBX-6636

The text All in the selection placeholder didn't make any sense. Changed it to None

Before change:
image

After change
image

For QA:

  • Create ContentType with ezselection ( multiselection NOT enabled ) with choices
    • BMW
    • Audi
    • Ford
  • Create content with new ContentType and check the placeholder

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vidarl vidarl changed the base branch from main to 4.6 November 13, 2024 13:52
@vidarl vidarl requested a review from a team November 13, 2024 14:32
adamwojs
adamwojs approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely make sense for me, but let's double check with @juskora and @NataliaBecla .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

Assignees

@mikadamczyk mikadamczyk

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vidarl @adamwojs @mikadamczyk