-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-7935: Handled User-related structs in FieldCollectionType
dispatcher
#64
Conversation
9272b28
to
aa1e6f9
Compare
Quality Gate passedIssues Measures |
@Steveb-p @konradoboza if you have some spare time please see https://github.com/ibexa/permissions/pull/17 as it's a part of the solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "register" scenario is this repo and in regression tests create product and create company scenarios are failing with this type of exception:
An error has occurred resolving the options of the form "Ibexa\User\Form\Type\UserRegisterType": The option "struct" with value null is expected to be of type "Ibexa\Contracts\Core\Repository\Values\Content\ContentCreateStruct" or "Ibexa\Contracts\Core\Repository\Values\Content\ContentUpdateStruct" or "Ibexa\Contracts\Core\Repository\Values\User\UserCreateStruct" or "Ibexa\Contracts\Core\Repository\Values\User\UserUpdateStruct", but is of type "null".
Current status: register OK |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Approved on Ibexa Commerce 4.6.7-dev (diff ok).
v4.6
The
FieldPermissionChecker
(https://github.com/ibexa/permissions/blob/4.5/src/lib/EventSubscriber/FieldPermissionCheckSubscriber.php#L46-L47) doesn't account for User-related structs likeUserCreateStruct
orUserUpdateStruct
, therefore those fields won't be disabled in case one is editing user content.The following PR creates some necessary events and dispatches them accordingly in the
FieldCollectionType
class :https://github.com/ibexa/content-forms/blob/main/src/lib/Form/Type/Content/FieldCollectionType.php.Related PR: https://github.com/ibexa/permissions/pull/17
Checklist:
@ibexa/engineering
).