Moved deprecation to default options callback

ibexa · Jul 10, 2024 · 5ebb8a8 · 5ebb8a8
1 parent 103b2c0
commit 5ebb8a8
Showing 1 changed file with 7 additions and 15 deletions.
diff --git a/src/lib/Form/Type/Content/BaseContentType.php b/src/lib/Form/Type/Content/BaseContentType.php
@@ -68,11 +68,17 @@ public function configureOptions(OptionsResolver $resolver)
     {
         $resolver
             ->setRequired(['languageCode', 'mainLanguageCode', 'struct'])
-            ->setDefault('struct', static function (Options $options, $value) {
+            ->setDefault('struct', static function (Options $options, ?ContentStruct $value) {
                 if ($value !== null) {
                     return $value;
                 }
 
+                trigger_deprecation(
+                    'ibexa/content-forms',
+                    'v4.6',
+                    'The option "struct" with null value is deprecated and will be required in v5.0.'
+                );
+
                 return $options['contentUpdateStruct']
                     ?? $options['contentCreateStruct']
                     ?? null;
@@ -101,20 +107,6 @@ public function configureOptions(OptionsResolver $resolver)
                 'ibexa/content-forms',
                 'v4.6.4',
                 'The option "%name%" is deprecated, use "struct" instead.'
-            )
-            ->setNormalizer(
-                'struct',
-                static function (Options $options, ?ContentStruct $value): ?ContentStruct {
-                    if ($value === null) {
-                        trigger_deprecation(
-                            'ibexa/content-forms',
-                            'v4.6',
-                            'The option "struct" with null value is deprecated and will be required in v5.0.'
-                        );
-                    }
-
-                    return $value;
-                }
             );
     }
 }