Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing exceptions to ElementAssert::isVisible #88

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Oct 5, 2023

Examplre failure:
https://github.com/ibexa/admin-ui/actions/runs/6420689702/job/17433347782

         Failed step: Then success notification that "Content published." appears
        Facebook\WebDriver\Exception\NoSuchElementException: no such element: Unable to locate element: {"method":"xpath","selector":"(//html/descendant-or-self::*[@class and contains(concat(' ', normalize-space(@class), ' '), ' ibexa-notifications-container ')]/descendant-or-self::*/*[@class and contains(concat(' ', normalize-space(@class), ' '), ' alert ')])[1]"}

Exceptions WebDriver\Exception\StaleElementReference and Webdriver\Exception\NoSuchElement are no longer relevant after upgrade to Selenium4 - they need to be replaced with Facebook\WebDriver\Exception\NoSuchElementException and Facebook\WebDriver\Exception\StaleElementReferenceException

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mnocon mnocon changed the title Added missing exception to ElementAssert::isVisible Added missing exceptions to ElementAssert::isVisible Oct 5, 2023
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@micszo micszo merged commit e24cb9c into 4.5 Oct 6, 2023
15 checks passed
@micszo micszo deleted the add-missing-exceptions branch October 6, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants