Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-5092: Moved test files #113

Merged
merged 3 commits into from
Jun 19, 2024
Merged

IBX-5092: Moved test files #113

merged 3 commits into from
Jun 19, 2024

Conversation

tomaszszopinski
Copy link
Contributor

@tomaszszopinski tomaszszopinski commented May 28, 2024

🎫 Issue IBX-5092

Related PRs:

Description:

Test files moved to behat bundle + changed test files path in yaml.

For QA:

@tomaszszopinski tomaszszopinski requested review from a team and juskora June 13, 2024 10:47
@tomaszszopinski tomaszszopinski marked this pull request as ready for review June 13, 2024 10:58
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can change the file name to quick_order_with_existing_products_template.csv because both files contains correct formatting. That's a minor, what do you think about it?

Copy link
Contributor Author

@tomaszszopinski tomaszszopinski Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the name to quick_order_template_with_existent_product.csv for it to sound better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can change the file name to quick_order_with_notexisting_products_template.csv because both files contains correct formatting. That's a minor, what do you think about it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here i changed the name to **quick_order_template_with_nonexistent_product.csv **

Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@micszo micszo merged commit d64be27 into 4.6 Jun 19, 2024
13 of 14 checks passed
@micszo micszo deleted the ibx-5092-quick-order-file-upload branch June 19, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants