IBX-6398: Adjust admin-ui for Image Picker component #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gengar-i
approved these changes
Oct 24, 2023
lucasOsti
approved these changes
Oct 25, 2023
dew326
requested changes
Oct 25, 2023
| 'adminUiConfig.universalDiscoveryWidget.tabs', | ||
| [ | ||
| { | ||
| id: 'image_picker', |
There was a problem hiding this comment.
adding the same tab with a different id? could you explain why?
additionally: admin-ui should not have any knowledge about image-picker
There was a problem hiding this comment.
I removed it. The backend part for overwriting config will be done in a separate PR.
GrabowskiM
approved these changes
Oct 26, 2023
| @@ -137,7 +137,23 @@ export const SearchTextContext = createContext(); | |||
| export const DropdownPortalRefContext = createContext(); | |||
|
|
|||
| const UniversalDiscoveryModule = (props) => { | |||
| const { tabs } = ibexa.adminUiConfig.universalDiscoveryWidget; | |||
| const { tabs: tabsWithPriority } = ibexa.adminUiConfig.universalDiscoveryWidget; | |||
| const tabs = tabsWithPriority.reduce((tabsPrioritized, tabToAdd) => { | |||
There was a problem hiding this comment.
maybe put it in memo? Not sure if it's easy as you have to pass array
There was a problem hiding this comment.
I removed this approach.
GrabowskiM
approved these changes
Nov 6, 2023
dew326
approved these changes
Nov 6, 2023
Gengar-i
approved these changes
Nov 8, 2023
lucasOsti
approved these changes
Nov 9, 2023
tischsoic
force-pushed
the
IBX-6398-image-picker-base
branch
from
5af47c7 to
d49ad07
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
micszo
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)