Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6547: Updated Popup modal #940

Merged
merged 6 commits into from
Nov 14, 2023
Merged

IBX-6547: Updated Popup modal #940

merged 6 commits into from
Nov 14, 2023

Conversation

Gengar-i
Copy link
Contributor

Question Answer
Tickets IBX-6547
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

IBX-6547: Updated Popup modal

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@Gengar-i Gengar-i requested a review from GrabowskiM October 13, 2023 15:33
@Gengar-i Gengar-i requested a review from GrabowskiM October 18, 2023 01:48
@Gengar-i Gengar-i force-pushed the ibx-6547-introduction-modal branch from 669150b to 1ba4930 Compare October 19, 2023 10:56
@Gengar-i Gengar-i requested a review from tischsoic October 26, 2023 08:12
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomaszszopinski tomaszszopinski mentioned this pull request Nov 9, 2023
Closed
tomaszszopinski
tomaszszopinski approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6 commerce.

@dew326 dew326 merged commit 9c89d0e into main Nov 14, 2023
16 of 17 checks passed
@dew326 dew326 deleted the ibx-6547-introduction-modal branch November 14, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees
No one assigned
Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Gengar-i @GrabowskiM @tischsoic @dew326 @lucasOsti @tomaszszopinski