Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6725: Autosave notification is in wrong place #938

Merged
merged 5 commits into from
Nov 3, 2023
Merged

IBX-6725: Autosave notification is in wrong place #938

merged 5 commits into from
Nov 3, 2023

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6725
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@GrabowskiM GrabowskiM force-pushed the IBX-6725-move-autosave branch 3 times, most recently from 913e90e to 209b103 Compare October 20, 2023 12:00
@GrabowskiM GrabowskiM force-pushed the IBX-6725-move-autosave branch from 209b103 to 59b316f Compare October 25, 2023 13:26
@GrabowskiM GrabowskiM force-pushed the IBX-6725-move-autosave branch from ba5b4e6 to 9b9b9d4 Compare October 31, 2023 14:13
@GrabowskiM GrabowskiM force-pushed the IBX-6725-move-autosave branch from 9b9b9d4 to dac3b08 Compare October 31, 2023 14:14
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tomaszszopinski
tomaszszopinski approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP commerce 4.6.x-dev

@ciastektk ciastektk merged commit ebec6ea into main Nov 3, 2023
17 checks passed
@ciastektk ciastektk deleted the IBX-6725-move-autosave branch November 3, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@GrabowskiM @dew326 @lucasOsti @Gengar-i @tomaszszopinski @mikadamczyk @Nattfarinn @ciastektk @ViniTou