Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6413: As an Editor, I'd to see autocomplete in global search #901

Merged
merged 10 commits into from
Nov 17, 2023
Merged

IBX-6413: As an Editor, I'd to see autocomplete in global search #901

merged 10 commits into from
Nov 17, 2023

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Sep 8, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6413
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kisztof kisztof force-pushed the search-autocomplete branch from 664eb42 to 164dda0 Compare October 26, 2023 11:26
@dew326 dew326 marked this pull request as ready for review October 30, 2023 12:50
@dew326 dew326 changed the title [WIP] IBX-6413: As an Editor, I'd to see autocomplete in global search IBX-6413: As an Editor, I'd to see autocomplete in global search Oct 30, 2023
@dew326 dew326 requested a review from GrabowskiM October 31, 2023 08:00
@dew326 dew326 force-pushed the search-autocomplete branch from 01a5b05 to 37f604e Compare October 31, 2023 13:59
@bogusez bogusez self-assigned this Nov 14, 2023
@kisztof kisztof force-pushed the search-autocomplete branch from 7deff40 to 72010e0 Compare November 14, 2023 14:44
@dew326 dew326 force-pushed the search-autocomplete branch from 72010e0 to 4f27dac Compare November 16, 2023 11:53
This was referenced Nov 16, 2023
Closed
Closed
Closed
@dew326 dew326 force-pushed the search-autocomplete branch from 4f27dac to 1c98598 Compare November 16, 2023 14:27
@dew326 dew326 force-pushed the search-autocomplete branch from 1c98598 to cebd451 Compare November 17, 2023 12:46
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bogusez
Copy link
Contributor

bogusez commented Nov 17, 2023

Regression tests passed:
ibexa/commerce#476
ibexa/experience#272
ibexa/headless#28

@dew326 dew326 merged commit 61a6687 into main Nov 17, 2023
14 of 23 checks passed
@dew326 dew326 deleted the search-autocomplete branch November 17, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

@bogusez bogusez

Labels
QA approved Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@dew326 @bogusez @GrabowskiM @lucasOsti @Gengar-i @mikadamczyk @Nattfarinn @ciastektk @ViniTou @kisztof