IBX-3698: Conditional icon for form_help #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
approved these changes
Aug 30, 2023
konradoboza
approved these changes
Aug 31, 2023
dew326
approved these changes
Aug 31, 2023
| @@ -383,10 +383,14 @@ | |||
| {% block form_help -%} | |||
| {%- if help is not empty -%} | |||
| {%- set help_attr = help_attr|merge({class: (help_attr.class|default('') ~ ' ibexa-form-help')|trim}) -%} | |||
| {%- set with_icon = help_attr.with_icon is defined ? help_attr.with_icon: true -%} | |||
There was a problem hiding this comment.
Suggested change
| {%- set with_icon = help_attr.with_icon is defined ? help_attr.with_icon: true -%} | |
| {%- set with_icon = help_attr.with_icon is defined ? help_attr.with_icon : true -%} |
?
lucasOsti
changed the title
Gengar-i
approved these changes
Sep 1, 2023
lucasOsti
force-pushed
the
IBX-3698-conditional-icon-form-help
branch
from
74e3485 to
20e86af
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added properties
help_attr.with_icon|default(true)to display icons in theform_helpblockChecklist:
$ composer fix-cs)