Skip to content

Commit

Permalink
IBX-9285: Navigation anchor on content creation/edition not working w…
Browse files Browse the repository at this point in the history
…ith diacritical marks
  • Loading branch information
lucasOsti committed Dec 13, 2024
1 parent 843ac71 commit e687286
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/lib/Menu/ContentEditAnchorMenuBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,10 @@ private function getContentFieldGroupItems(array $groupedFields): array
$order = 0;
foreach ($groupedFields as $group => $fields) {
$order += self::ITEM_ORDER_SPAN;
$groupNameASCII = transliterator_transliterate('Any-Latin; Latin-ASCII', $group);
$items[$group] = $this->createMenuItem($group, [
'attributes' => [
'data-target-id' => sprintf('ibexa-edit-content-sections-content-fields-%s', str_replace(' ', '-', mb_strtolower($group))),
'data-target-id' => sprintf('ibexa-edit-content-sections-content-fields-%s', str_replace(' ', '-', mb_strtolower($groupNameASCII))),

Check failure on line 110 in src/lib/Menu/ContentEditAnchorMenuBuilder.php

View workflow job for this annotation

GitHub Actions / Tests (8.3)

Parameter #1 $string of function mb_strtolower expects string, string|false given.
],
'extras' => [
'orderNumber' => $order,
Expand All @@ -115,6 +116,8 @@ private function getContentFieldGroupItems(array $groupedFields): array
}

return $items;

return $items;

Check failure on line 120 in src/lib/Menu/ContentEditAnchorMenuBuilder.php

View workflow job for this annotation

GitHub Actions / Tests (8.3)

Unreachable statement - code above always terminates.
}

/**
Expand Down

0 comments on commit e687286

Please sign in to comment.