Frontend PR #3
Open
Frontend PR #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lutif
suggested changes
Aug 15, 2021
context/UsersContext.jsx
Outdated
| const UsersContext = createContext(); | ||
|
|
||
| export function UsersWrapper({ children }) { | ||
| const [user,setUser]= useState([]) |
pages/components/ChatBox.jsx
Outdated
| padding: 1rem !important; | ||
|
|
||
|
|
||
| ` |
pages/components/ChatBox.jsx
Outdated
| const [mObj,setmObj]=useState({}) | ||
| const [messageList,setMessageList]= useState([]) | ||
| const messagesEndRef = useRef(null) | ||
| const context= useUsersContext() |
pages/components/ChatBox.jsx
Outdated
| const [socketState, setSocketState]=useState() | ||
| //console.log("We've Re-rendered") | ||
|
|
||
| let socketRef= null |
There was a problem hiding this comment.
will sockedState and socketRef be always the same?
pages/components/ChatBox.jsx
Outdated
| message:event.target.value, | ||
| to:selectedContact, | ||
| from:context.user.name, | ||
| time:new Date().toLocaleTimeString([], |
There was a problem hiding this comment.
why not set these params before sending messages instead of setting them again and again on each character change?
pages/components/ChatBox.jsx
Outdated
| </div> | ||
| </ContactColumn> | ||
|
|
||
| <ChatColumn style={{border:'1px solid black', 'border-radius':'10px'}}> |
pages/components/ChatBox.jsx
Outdated
| { | ||
| messageList?.map( message => { | ||
| if(message.from===selectedContact || (message.from === context.user.name && message.to=== selectedContact)) | ||
| return <div key={dummy()} style={{overflow: 'hidden'}}> |
pages/components/ChatBox.jsx
Outdated
| if(user.name !== context.user.name){ | ||
| return ( | ||
| <ContactListItem | ||
| key={dummy()} |
pages/components/ChatBox.jsx
Outdated
| if(message.from===selectedContact || (message.from === context.user.name && message.to=== selectedContact)) | ||
| return <div key={dummy()} style={{overflow: 'hidden'}}> | ||
| { message.from=== context.user.name ? | ||
| <Message style={{float:'right',backgroundColor:'#E1EBEE'}}>{ message.message }<span>{message.time}</span></Message> |
pages/components/ChatBox.jsx
Outdated
| </div> | ||
| }) | ||
| } | ||
| <div ref={messagesEndRef} /> |
There was a problem hiding this comment.
can you find a better way to get auto-scroll functionality .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.