Request to merge work from GSOC 2024: all the tests are finally passing #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-genbank-tests Update to match new NCBI record
|
I have confirmed that the test that is failing here is passing in the branch being merged, and thus should not have a problem once credentials are local. |
jakebeal
approved these changes
Aug 27, 2024
scripts/test/test_files/package.nt
Outdated
There was a problem hiding this comment.
This looks like an accidental commit, duplicating the one in views/package.nt
Please try to remove it and see if that breaks any tests.
There was a problem hiding this comment.
I double checked and it is not an accidental commit. I use the file for testing purposes in test_compute_complexity_score.py on line 31. I took the package.nt file from the RBS-Collection repository and didn't rename it appropiately. I changed the name of the file to package_RBS_Collection.nt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression test will probably fail because we need to set up the IDT credentials as a GitHub secret in the parent iGEM-Engineering/iGEM-actions repository