Add a Helm CI Check #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the helm/chart-testing-action to do basic linting and testing of of the helm charts.
A 'charts' dir is used more consistently across the Helm community as well as for the 'ct' cli tool. This renames the 'helm' dir to 'charts' to align with these conventions.
Two-spaces are needed for inline comments.
djmetzle
reviewed
Feb 7, 2024
|
|
||
| - name: Create kind cluster | ||
| if: steps.list-changed.outputs.changed == 'true' | ||
| uses: helm/[email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a very basic check for our Helm charts. While this action is the main entry-point, it is using this CLI tool under the hood https://github.com/helm/chart-testing.
CR
This does a very basic check on our Helm charts. It validates the Chart schema and values.yaml file. It will then use
kindto attempt to install the Helm charts. However, it will not validate the final manifests that were deployed to thekindcluster nor if the actualCronJobworked. It will simply check it was successful in installing the Helm chart.That said, we don't expect a lot of
churnfor this repo, or the charts, which resulted in the decision to not pursue extensive testing. For example, with tools like Terratest to check if theCronJobworked or the use of golden files to validate the final manifests that were deployed.QA
qa_req 0 CI should pass as I already tested the action prior to this pull
Closes: #23