-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add a Helm Chart for Vigilo #21
Conversation
We will be using a Kubernetes CronJob to run Vigilo periodically. This add the initial template for the CronJob.
This will template out the name CronJob name and the container image configuration. Vigilo is not currently publishing images to Docker Hub, so there is no default image to use.
To run Vigilo, we need to have a `url.json` file and a `lh-config.js` file within the container. This can be seen in `dev-scripts/run-docker.sh` file when running the docker container directly. Therefore, in order to add these files to the cronjob container we will volume mount them. To do that, we need to create a configmap for each of these files to be mounted. As such, this adds a configmap template for the `lh-config.js` file and `urls.json` file which can then be modified in the `values.yaml` file.
The last bit to getting the helm chart working is to add a secret for the DataDog credentials (i.e. the .env file). This adds a secret template and updates the cronjob to include the secret. The creation of the secret can be turned off and we can point to a different secret if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any helm linters that we can enable in this repo?
maybe https://github.com/marketplace/actions/helm-chart-testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR ❓ It's a bit hard to CR this as I'm not very familiar with helm chart generation. Kinda one of those things we just need to QA I think.
There are a couple things I want to add to help automate some of the Helm stuff. For instance, the usage of That said, I think we should create follow-up issues to address the testing aspect. |
This is still in the early phases for us, so manual testing will be the initial validation to the charts. That said, one thing I should point out is that unlike some of the other Helm Charts we've interacted with, this uses a CronJob instead of a |
Description
This mainly follows examples I've seen from other Helm Charts. The entire premise to be able to routinely kick off a lighthouse audit as part of our Kubernetes cluster. This will detach the dependency of having Lighthouse running on our Ubreakit machine and instead will be ran through a Pod.
As such, it will be a lot easier if we have a Helm Chart for all this instead of manually creating the manifests ourselves in our FluxCD repo.
QA
Note
This will be difficult to QA as is, we will need to manually test by integrating the Helm Chart into our current Test cluster.
GitRepository
FluxCD resourceCloses: #16
Connects: https://github.com/iFixit/ifixit/issues/49455