Skip to content

Commit

Permalink
gh actions: apply masking option to ecr login
Browse files Browse the repository at this point in the history
There is a warning about the 'mask-password' option for the
"amazon-ecr-login" action. If ran in debug mode, the password will be
outputted. By default this option is not enabled as the expectation is
to run the service after the deployment but as a secondary job. As
such the password cannot be masked as it is needed to run the service.

https://github.com/aws-actions/amazon-ecr-login#run-an-image-as-a-service

However, this is not the workflow we have set up, therefore we need to
enable the option to mask the password.
  • Loading branch information
ardelato committed Dec 11, 2023
1 parent 2af897a commit 5a0b9bc
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/build-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ jobs:
- name: Login to Amazon ECR
id: login-ecr
uses: aws-actions/amazon-ecr-login@v1
with:
mask-password: true

- name: Build, Tag, and Push Image to Amazon ECR
env:
Expand Down

0 comments on commit 5a0b9bc

Please sign in to comment.