PopSQL: add psalm, gh actions, param/return types #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmetzle
previously approved these changes
Aug 20, 2024
QueryGenerator.php
Outdated
| return array_keys(self::$possibleClauses); | ||
| } | ||
|
|
||
| /** | ||
| * Return the primary clause in this QueryGenerator instance. | ||
| * If multiple primary clauses have been set, all but the first set clause | ||
| * will be ignored. | ||
| * | ||
| * @return string|false |
There was a problem hiding this comment.
This isn't necessary. false is a literal type now (as of 8.0):
https://php.watch/versions/8.0/union-types#false
QueryGenerator.php
Outdated
| @@ -441,8 +464,10 @@ private function constructClause($method, $skipClause = false) { | |||
| /** | |||
| * return the appropriate glue string for the given clause, taking into | |||
| * account $this->useOr | |||
| * | |||
| * @return string|false | |||
Maybe so. I think the only argument for keeping it separate is that it might be useful to the open source community, but that's probably far-fetched |
|
@davidrans sure. We dont have to archive it. And even if we did, it would still be publicly available. Its not widely used: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
Closes #4