-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contracts verification script #46
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
508eb09
Add guide to verify voucher contracts
zguesmi 172df0e
Update readme
zguesmi 4c04525
Clean hardhat file
zguesmi 0137a9a
Merge branch 'develop' into feature/verify-contracts
zguesmi 353e30f
Add verification script
zguesmi 47b912c
Clean
zguesmi fb30894
Fix CI
zguesmi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
// SPDX-FileCopyrightText: 2024 IEXEC BLOCKCHAIN TECH <[email protected]> | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
import hre, { deployments, ethers } from 'hardhat'; | ||
import { UpgradeableBeacon__factory, VoucherHub__factory } from '../typechain-types'; | ||
|
||
/** | ||
* Note: When verifying a proxy contract, Hardhat-verify combined with Openzeppelin Upgrades | ||
* plugin is "generally" able to automatically detect and verify the implementation contract. | ||
* Here we explicitly verify the implementation because some issues have been observed. | ||
*/ | ||
|
||
(async () => { | ||
const upgraderAddress = process.env.VOUCHER_UPGRADER_ADDRESS || ''; | ||
const managerAddress = process.env.VOUCHER_MANAGER_ADDRESS || ''; | ||
const minterAddress = process.env.VOUCHER_MINTER_ADDRESS || ''; | ||
|
||
const voucherImplAddress = (await deployments.get('VoucherImpl')).address; | ||
const voucherUpgradableBeaconAddress = (await deployments.get('VoucherUpgradeableBeacon')) | ||
.address; | ||
const voucherHubImplAddress = (await deployments.get('VoucherHubImpl')).address; | ||
const voucherHubERC1967ProxyAddress = (await deployments.get('VoucherHubERC1967Proxy')).address; | ||
|
||
const beaconInitialOwnerAddress = await UpgradeableBeacon__factory.connect( | ||
voucherUpgradableBeaconAddress, | ||
ethers.provider, | ||
).owner(); // Will not work if the owner was changed after deployment. | ||
const voucherHub = VoucherHub__factory.connect(voucherHubERC1967ProxyAddress, ethers.provider); | ||
const iexecPocoAddress = await voucherHub.getIexecPoco(); | ||
|
||
const contracts = [ | ||
{ | ||
name: 'VoucherImpl', | ||
address: voucherImplAddress, | ||
args: [], | ||
}, | ||
{ | ||
name: 'VoucherUpgradeableBeacon', | ||
address: voucherUpgradableBeaconAddress, | ||
args: [[voucherImplAddress, beaconInitialOwnerAddress]], | ||
}, | ||
{ | ||
name: 'VoucherHubImpl', | ||
address: voucherHubImplAddress, | ||
args: [], | ||
}, | ||
{ | ||
name: 'VoucherHubERC1967Proxy', | ||
address: voucherHubERC1967ProxyAddress, | ||
args: [ | ||
voucherHubImplAddress, | ||
VoucherHub__factory.createInterface().encodeFunctionData('initialize', [ | ||
upgraderAddress, | ||
managerAddress, | ||
minterAddress, | ||
iexecPocoAddress, | ||
voucherUpgradableBeaconAddress, | ||
]), | ||
], | ||
}, | ||
]; | ||
|
||
for (const contract of contracts) { | ||
console.log(`<> Verifying ${contract.name}`); | ||
await hre.run('verify:verify', { | ||
address: contract.address, | ||
constructorArguments: contract.args, | ||
}); | ||
} | ||
})().catch((error) => console.log(error)); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI would fail without this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmh ok I see, if it's fails then we should change it ! But I don't get what are the root cause of this change. That was due to a modification, evmVersion: 'berlin', ?