Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright notice and formatting of module delegates #69

Draft
wants to merge 2 commits into
base: feature/format-solidity-interfaces
Choose a base branch
from

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Apr 22, 2024

No description provided.

@zguesmi zguesmi self-assigned this Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 56.31868% with 159 lines in your changes are missing coverage. Please review.

Project coverage is 78.88%. Comparing base (394a04a) to head (e37c9b8).

Files Patch % Lines
...modules/delegates/IexecEscrowTokenSwapDelegate.sol 0.00% 66 Missing ⚠️
...ts/modules/delegates/IexecEscrowNativeDelegate.sol 0.00% 35 Missing ⚠️
contracts/modules/delegates/SignatureVerifier.sol 42.00% 29 Missing ⚠️
...racts/modules/delegates/IexecAccessorsDelegate.sol 75.75% 16 Missing ⚠️
...cts/modules/delegates/IexecEscrowTokenDelegate.sol 84.21% 6 Missing ⚠️
...odules/delegates/IexecMaintenanceExtraDelegate.sol 0.00% 5 Missing ⚠️
...ules/delegates/IexecAccessorsABILegacyDelegate.sol 90.00% 2 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           feature/format-solidity-interfaces      #69      +/-   ##
======================================================================
- Coverage                               79.96%   78.88%   -1.09%     
======================================================================
  Files                                      34       34              
  Lines                                    1118     1146      +28     
  Branches                                  226      216      -10     
======================================================================
+ Hits                                      894      904      +10     
- Misses                                    224      242      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gfournieriExec gfournieriExec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants