Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sticky header out of the way so foreground touches work #112

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nicotroia
Copy link

Touchable items in the foreground are currently blocked when they are positioned over the sticky header.

This change animates the sticky header to move it out of the way before the user scrolls up, allowing presses to happen in that area.

Copy link

@flikQ flikQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR causes issue:

Invariant Violation: Transform with key of "translateY" must be a number:
{"translateY": -70}

the -70 being the height set by stickyHeaderHeight prop

@flikQ
Copy link

flikQ commented Sep 6, 2018

ok found the issue, you forgot an Animated.View on the stickyheader container.

Make parent View Animated
@nicotroia
Copy link
Author

@flikQ Good catch, fixed

@Aloving
Copy link

Aloving commented Nov 15, 2018

What now, will it be merged?

Copy link

@maherzaidoune maherzaidoune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine , press detected on Foreground

@dsgoers
Copy link

dsgoers commented Mar 6, 2019

Any update on this? This fix would really help my project.

@Josephdias92
Copy link

Please merge this. I'm stuck coz of this issue

darcien added a commit to darcien/react-native-parallax-scroll-view that referenced this pull request Apr 16, 2019
@charro0407
Copy link

You are a Hero!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants