-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move sticky header out of the way so foreground touches work #112
base: master
Are you sure you want to change the base?
Move sticky header out of the way so foreground touches work #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR causes issue:
Invariant Violation: Transform with key of "translateY" must be a number:
{"translateY": -70}
the -70 being the height set by stickyHeaderHeight prop
ok found the issue, you forgot an Animated.View on the stickyheader container. |
Make parent View Animated
@flikQ Good catch, fixed |
What now, will it be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works fine , press detected on Foreground
Any update on this? This fix would really help my project. |
Please merge this. I'm stuck coz of this issue |
You are a Hero! |
Touchable items in the foreground are currently blocked when they are positioned over the sticky header.
This change animates the sticky header to move it out of the way before the user scrolls up, allowing presses to happen in that area.