Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom namespaced functions and components #913

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

taneliang
Copy link
Contributor

Why am I submitting this PR

To support matching namespaced functions and components like Strings.get and <Strings.Text>.

Does it fix an existing ticket?

Yes #912

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • tests are included and pass: yarn test (see details here)
  • documentation is changed or added – I'll be happy to add docs for this, but the existing docs should already be enough

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
src/lexers/javascript-lexer.js 95.81% <100.00%> (+0.29%) ⬆️
src/lexers/jsx-lexer.js 98.55% <100.00%> (+0.01%) ⬆️

📢 Thoughts on this report? Let us know!.

@karellm karellm merged commit e7977ef into i18next:master Oct 1, 2023
4 checks passed
@karellm
Copy link
Member

karellm commented Oct 1, 2023

Thanks, this is in 8.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants