chore: upgrade husky config to v9 #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripecosta
commented
Aug 12, 2024
There was a problem hiding this comment.
Husky v9 no longer needs this .gitignore file. The _ folder itself contains one that does exactly the same.
ripecosta
commented
Aug 12, 2024
There was a problem hiding this comment.
Husky v9 no longer requires this file to be have executable permissions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
- Coverage 95.40% 95.35% -0.05%
==========================================
Files 11 10 -1
Lines 1937 1918 -19
==========================================
- Hits 1848 1829 -19
Misses 89 89 ☔ View full report in Codecov by Sentry. |
|
Rebased the PR to fix merge conflicts and it's ready to go now. CC: @karellm |
|
You bit to it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why am I submitting this PR
Upgrade husky config to v9. V9 was already in use but still using the legacy config method.
Also replaces the npx commands with yarn commands because there's not need to use npx since yarn already installs lint-staged.
Does it fix an existing ticket?
No
Checklist
yarn test(see details here)