Debian packaging overhaul #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Total -- 2,149.15kb -> 1,907.18kb (11.26%) /I-Nex/i-nex/Database/Distlogos/mint_mate.png -- 93.96kb -> 12.64kb (86.54%) /I-Nex/i-nex/Data/donate.png -- 4.40kb -> 2.07kb (53.01%) /I-Nex/i-nex/Database/Logos/237.gif -- 5.24kb -> 4.03kb (23.02%) /I-Nex/i-nex/Database/Logos/241.gif -- 5.27kb -> 4.07kb (22.87%) /I-Nex/i-nex/Database/Logos/242.gif -- 5.27kb -> 4.07kb (22.87%) /I-Nex/i-nex/AppIcons/view-refresh.png -- 1.25kb -> 0.98kb (21.76%) /I-Nex/i-nex/AppIcons/Finfosys/applications-system.png -- 0.77kb -> 0.63kb (18.86%) /I-Nex/i-nex/Database/Logos/302.gif -- 6.80kb -> 5.57kb (18%) /I-Nex/i-nex/Database/Logos/57.gif -- 5.75kb -> 4.73kb (17.75%) /I-Nex/i-nex/Database/Logos/234.gif -- 5.75kb -> 4.73kb (17.75%) /I-Nex/i-nex/Database/Logos/192.gif -- 6.74kb -> 5.54kb (17.74%) /I-Nex/i-nex/Database/Logos/193.gif -- 6.81kb -> 5.62kb (17.55%) /I-Nex/i-nex/Database/Logos/303.gif -- 7.00kb -> 5.78kb (17.46%) /I-Nex/i-nex/Database/Logos/304.gif -- 7.04kb -> 5.81kb (17.39%) /I-Nex/i-nex/Database/Logos/235.gif -- 5.92kb -> 4.90kb (17.24%) /I-Nex/i-nex/Database/Logos/305.gif -- 7.10kb -> 5.87kb (17.24%) /I-Nex/i-nex/Database/Logos/299.gif -- 7.32kb -> 6.09kb (16.73%) /I-Nex/i-nex/Database/Logos/298.gif -- 7.35kb -> 6.13kb (16.65%) /I-Nex/i-nex/Database/Logos/297.gif -- 7.40kb -> 6.18kb (16.53%) /I-Nex/i-nex/Database/Logos/223.gif -- 7.35kb -> 6.14kb (16.47%) /I-Nex/i-nex/Database/Logos/217.gif -- 7.35kb -> 6.14kb (16.47%) /I-Nex/i-nex/Database/Logos/224.gif -- 7.35kb -> 6.14kb (16.47%) /I-Nex/i-nex/Database/Logos/216.gif -- 7.35kb -> 6.14kb (16.47%) /I-Nex/i-nex/Database/Logos/220.gif -- 7.35kb -> 6.14kb (16.47%) /I-Nex/i-nex/Database/Logos/221.gif -- 7.35kb -> 6.14kb (16.47%) /I-Nex/i-nex/Database/Logos/215.gif -- 7.35kb -> 6.14kb (16.47%) /I-Nex/i-nex/Database/Logos/222.gif -- 7.35kb -> 6.14kb (16.47%) /I-Nex/i-nex/Database/Logos/225.gif -- 7.50kb -> 6.29kb (16.15%) /I-Nex/i-nex/Database/Logos/228.gif -- 7.53kb -> 6.32kb (16.07%) /I-Nex/i-nex/Database/Logos/229.gif -- 7.53kb -> 6.32kb (16.07%) /I-Nex/i-nex/Database/Distlogos/opensuse.png -- 16.42kb -> 13.90kb (15.38%) /I-Nex/i-nex/Database/Logos/100.gif -- 6.74kb -> 5.74kb (14.87%) /I-Nex/i-nex/Database/Logos/102.gif -- 6.76kb -> 5.76kb (14.83%) /I-Nex/i-nex/Database/Logos/48.gif -- 6.76kb -> 5.76kb (14.83%) /I-Nex/i-nex/Database/Logos/275.gif -- 6.76kb -> 5.76kb (14.83%) /I-Nex/i-nex/Database/Logos/67.gif -- 8.28kb -> 7.07kb (14.62%) /I-Nex/i-nex/Database/Logos/65.gif -- 8.44kb -> 7.23kb (14.35%) /I-Nex/i-nex/Database/Logos/130.gif -- 8.51kb -> 7.30kb (14.22%) /I-Nex/i-nex/Database/Logos/98.gif -- 8.51kb -> 7.30kb (14.22%) /I-Nex/i-nex/Database/Logos/126.gif -- 8.51kb -> 7.30kb (14.22%) /I-Nex/i-nex/Database/Logos/47.gif -- 7.18kb -> 6.16kb (14.22%) /I-Nex/i-nex/Database/Logos/248.gif -- 7.18kb -> 6.16kb (14.22%) /I-Nex/i-nex/Database/Logos/249.gif -- 7.18kb -> 6.16kb (14.22%) /I-Nex/i-nex/Database/Logos/296.gif -- 7.19kb -> 6.17kb (14.19%) /I-Nex/i-nex/Database/Logos/300.gif -- 8.66kb -> 7.43kb (14.13%) /I-Nex/i-nex/Database/Logos/99.gif -- 7.22kb -> 6.20kb (14.13%) /I-Nex/i-nex/Database/Logos/312.gif -- 8.67kb -> 7.45kb (14.12%) /I-Nex/i-nex/Database/Logos/301.gif -- 8.67kb -> 7.45kb (14.12%) /I-Nex/i-nex/Database/Logos/127.gif -- 8.63kb -> 7.42kb (14.04%) /I-Nex/i-nex/Database/Logos/125.gif -- 8.63kb -> 7.42kb (14.04%) /I-Nex/i-nex/Database/Logos/134.gif -- 8.63kb -> 7.42kb (14.04%) /I-Nex/i-nex/Database/Logos/129.gif -- 8.63kb -> 7.42kb (14.04%) /I-Nex/i-nex/AppIcons/gtk-yes.png -- 0.82kb -> 0.71kb (13.81%) /I-Nex/i-nex/Database/Distlogos/elementaryos.png -- 16.23kb -> 14.09kb (13.14%) /I-Nex/i-nex/Database/Logos/138.gif -- 9.29kb -> 8.08kb (13.02%) /I-Nex/i-nex/Database/Logos/122.gif -- 9.37kb -> 8.16kb (12.93%) /I-Nex/i-nex/Database/Logos/123.gif -- 9.37kb -> 8.16kb (12.93%) /I-Nex/i-nex/Database/Logos/306.gif -- 8.00kb -> 6.98kb (12.75%) /I-Nex/i-nex/Database/Logos/13.gif -- 9.43kb -> 8.23kb (12.68%) /I-Nex/i-nex/Database/Logos/283.gif -- 8.04kb -> 7.02kb (12.67%) /I-Nex/i-nex/Database/Logos/329.gif -- 8.04kb -> 7.02kb (12.67%) /I-Nex/i-nex/Database/Logos/321.gif -- 8.04kb -> 7.02kb (12.67%) /I-Nex/i-nex/Database/Logos/311.gif -- 8.20kb -> 7.18kb (12.43%) /I-Nex/i-nex/Database/Logos/315.gif -- 8.20kb -> 7.18kb (12.43%) /I-Nex/i-nex/Database/Logos/33.gif -- 8.29kb -> 7.26kb (12.33%) /I-Nex/i-nex/Database/Logos/32.gif -- 8.30kb -> 7.28kb (12.29%) /I-Nex/i-nex/Database/Logos/38.gif -- 8.32kb -> 7.30kb (12.26%) /I-Nex/i-nex/Database/Logos/96.gif -- 9.73kb -> 8.54kb (12.24%) /I-Nex/i-nex/Database/Logos/70.gif -- 9.73kb -> 8.54kb (12.24%) /I-Nex/i-nex/Database/Logos/71.gif -- 9.73kb -> 8.54kb (12.24%) /I-Nex/i-nex/Database/Logos/97.gif -- 9.73kb -> 8.54kb (12.24%) /I-Nex/i-nex/Database/Logos/77.gif -- 9.73kb -> 8.54kb (12.24%) /I-Nex/i-nex/Database/Logos/72.gif -- 9.73kb -> 8.54kb (12.24%) /I-Nex/i-nex/Database/Logos/68.gif -- 9.73kb -> 8.54kb (12.24%) /I-Nex/i-nex/Database/Distlogos/kde_neon.png -- 10.50kb -> 9.22kb (12.23%) /I-Nex/i-nex/Database/Logos/121.gif -- 11.54kb -> 10.13kb (12.19%) /I-Nex/i-nex/Database/Logos/120.gif -- 11.54kb -> 10.13kb (12.19%) /I-Nex/i-nex/Database/Logos/108.gif -- 9.94kb -> 8.73kb (12.18%) /I-Nex/i-nex/Database/Logos/318.gif -- 8.39kb -> 7.37kb (12.15%) /I-Nex/i-nex/Database/Logos/310.gif -- 8.39kb -> 7.37kb (12.15%) /I-Nex/i-nex/Database/Logos/291.gif -- 8.39kb -> 7.37kb (12.15%) /I-Nex/i-nex/Database/Logos/116.gif -- 9.84kb -> 8.64kb (12.15%) /I-Nex/i-nex/Database/Logos/34.gif -- 8.36kb -> 7.36kb (11.99%) /I-Nex/i-nex/Database/Logos/290.gif -- 8.52kb -> 7.50kb (11.99%) /I-Nex/i-nex/Database/Logos/105.gif -- 11.82kb -> 10.41kb (11.96%) /I-Nex/i-nex/Database/Logos/104.gif -- 11.82kb -> 10.41kb (11.96%) /I-Nex/i-nex/Database/Logos/261.gif -- 11.82kb -> 10.41kb (11.96%) /I-Nex/i-nex/Database/Logos/313.gif -- 8.56kb -> 7.53kb (11.96%) /I-Nex/i-nex/Database/Logos/107.gif -- 10.13kb -> 8.92kb (11.95%) /I-Nex/i-nex/Database/Logos/309.gif -- 8.53kb -> 7.51kb (11.95%) /I-Nex/i-nex/Database/Logos/316.gif -- 8.53kb -> 7.51kb (11.95%) /I-Nex/i-nex/Database/Logos/28.gif -- 8.66kb -> 7.64kb (11.79%) /I-Nex/i-nex/Database/Logos/63.gif -- 8.66kb -> 7.64kb (11.79%) /I-Nex/i-nex/Database/Logos/139.gif -- 10.30kb -> 9.09kb (11.76%) /I-Nex/i-nex/Database/Logos/206.gif -- 8.69kb -> 7.67kb (11.75%) /I-Nex/i-nex/Database/Logos/288.gif -- 8.69kb -> 7.67kb (11.75%) /I-Nex/i-nex/Database/Logos/110.gif -- 10.29kb -> 9.08kb (11.74%) /I-Nex/i-nex/Database/Logos/247.gif -- 8.70kb -> 7.68kb (11.73%) /I-Nex/i-nex/Database/Logos/273.gif -- 8.70kb -> 7.68kb (11.73%) /I-Nex/i-nex/Database/Logos/211.gif -- 8.70kb -> 7.68kb (11.73%) /I-Nex/i-nex/Database/Logos/203.gif -- 8.70kb -> 7.68kb (11.73%) /I-Nex/i-nex/Database/Logos/246.gif -- 10.48kb -> 9.27kb (11.56%) /I-Nex/i-nex/Database/Logos/60.gif -- 9.91kb -> 8.77kb (11.46%) /I-Nex/i-nex/Database/Logos/59.gif -- 9.86kb -> 8.75kb (11.28%) /I-Nex/i-nex/Database/Logos/31.gif -- 10.85kb -> 9.65kb (11.09%) /I-Nex/i-nex/Database/Logos/159.gif -- 9.24kb -> 8.22kb (11.05%) /I-Nex/i-nex/Database/Logos/12.gif -- 9.24kb -> 8.22kb (11.05%) /I-Nex/i-nex/Database/Logos/271.gif -- 9.25kb -> 8.23kb (11.04%) /I-Nex/i-nex/Database/Logos/268.gif -- 9.25kb -> 8.23kb (11.04%) /I-Nex/i-nex/Database/Logos/274.gif -- 9.25kb -> 8.23kb (11.04%) /I-Nex/i-nex/Database/Logos/272.gif -- 9.25kb -> 8.23kb (11.04%) /I-Nex/i-nex/Database/Logos/269.gif -- 9.25kb -> 8.23kb (11.04%) /I-Nex/i-nex/Database/Logos/263.gif -- 9.25kb -> 8.23kb (11.04%) /I-Nex/i-nex/Database/Logos/56.gif -- 9.25kb -> 8.23kb (11.04%) /I-Nex/i-nex/Database/Logos/267.gif -- 9.25kb -> 8.23kb (11.04%) /I-Nex/i-nex/Database/Logos/50.gif -- 9.27kb -> 8.25kb (11.01%) /I-Nex/i-nex/Database/Logos/81.gif -- 9.27kb -> 8.25kb (11.01%) /I-Nex/i-nex/Database/Logos/160.gif -- 9.40kb -> 8.38kb (10.87%) /I-Nex/i-nex/Database/Logos/154.gif -- 9.40kb -> 8.38kb (10.87%) /I-Nex/i-nex/Data/check_false.png -- 0.74kb -> 0.66kb (10.86%) /I-Nex/i-nex/Database/Logos/287.gif -- 9.44kb -> 8.42kb (10.82%) /I-Nex/i-nex/AppIcons/application-default-icon.png -- 0.64kb -> 0.58kb (10.35%) /I-Nex/i-nex/Database/Logos/262.gif -- 10.57kb -> 9.55kb (9.66%) /I-Nex/i-nex/Database/Logos/266.gif -- 10.57kb -> 9.55kb (9.66%) /I-Nex/i-nex/Database/Logos/270.gif -- 10.66kb -> 9.64kb (9.58%) /I-Nex/i-nex/Database/Logos/265.gif -- 10.66kb -> 9.64kb (9.58%) /I-Nex/i-nex/Database/Distlogos/kubuntu.png -- 9.83kb -> 8.89kb (9.54%) /I-Nex/i-nex/Database/Logos/119.gif -- 10.61kb -> 9.60kb (9.46%) /I-Nex/i-nex/Database/Logos/158.gif -- 10.61kb -> 9.60kb (9.46%) /I-Nex/i-nex/Database/Logos/244.gif -- 12.69kb -> 11.50kb (9.42%) /I-Nex/i-nex/Database/Logos/243.gif -- 12.69kb -> 11.50kb (9.42%) /I-Nex/i-nex/Database/Logos/84.gif -- 10.91kb -> 9.89kb (9.36%) /I-Nex/i-nex/Database/Logos/308.gif -- 12.02kb -> 11.03kb (8.26%) /I-Nex/i-nex/Database/Logos/317.gif -- 12.02kb -> 11.03kb (8.26%) /I-Nex/i-nex/Data/check_true.png -- 0.69kb -> 0.64kb (7.5%) /I-Nex/i-nex/Database/Distlogos/redhat.png -- 15.29kb -> 14.29kb (6.54%) /I-Nex/i-nex/AppIcons/help-about.png -- 0.69kb -> 0.64kb (6.38%) /I-Nex/i-nex/Database/Distlogos/manjaro.png -- 9.53kb -> 9.06kb (4.94%) /I-Nex/i-nex/Database/Distlogos/mint.png -- 16.98kb -> 16.17kb (4.78%) /pixmaps/i-nex.png -- 25.09kb -> 24.03kb (4.22%) /I-Nex/i-nex/logo/i-nex.0.4.x.png -- 25.09kb -> 24.03kb (4.22%) /I-Nex/i-nex/192.png -- 20.16kb -> 19.40kb (3.78%) /I-Nex/i-nex/Database/Distlogos/xubuntu.png -- 16.86kb -> 16.30kb (3.32%) /I-Nex/i-nex/.icon.png -- 14.32kb -> 13.87kb (3.14%) /I-Nex/i-nex/Database/Distlogos/LinuxDeepin.png -- 12.36kb -> 11.98kb (3.06%) /I-Nex/i-nex/Database/Distlogos/netrunner.png -- 16.37kb -> 15.94kb (2.64%) /pixmaps/i-nex-128.png -- 11.07kb -> 10.78kb (2.63%) /I-Nex/i-nex/Database/Distlogos/debian.png -- 17.16kb -> 16.74kb (2.45%) /I-Nex/i-nex/Database/Distlogos/sabayon.png -- 16.66kb -> 16.26kb (2.4%) /I-Nex/i-nex/Database/Distlogos/archlinux.png -- 12.95kb -> 12.64kb (2.37%) /I-Nex/i-nex/Database/Distlogos/linux_mint_LMDE_Big_sticker.png -- 21.99kb -> 21.48kb (2.31%) /I-Nex/i-nex/Database/Distlogos/mandriva.png -- 15.24kb -> 14.93kb (2.07%) /I-Nex/i-nex/Database/Distlogos/fedora.png -- 17.17kb -> 16.83kb (2.01%) /I-Nex/i-nex/Database/Distlogos/linux_mint_Fluxbox_BIG_sticker.png -- 23.51kb -> 23.04kb (1.99%) /I-Nex/i-nex/Database/Distlogos/linux_mint_XFCE_Big_sticker.png -- 24.61kb -> 24.13kb (1.95%) /I-Nex/i-nex/Database/Distlogos/ubuntu.png -- 14.45kb -> 14.17kb (1.89%) /I-Nex/i-nex/Database/Distlogos/linux_mint_LXDE_BIG_sticker.png -- 20.24kb -> 19.86kb (1.86%) /I-Nex/i-nex/Database/Distlogos/gentoo.png -- 19.85kb -> 19.52kb (1.62%) /I-Nex/i-nex/Database/Distlogos/slackware.png -- 20.46kb -> 20.13kb (1.62%) /I-Nex/i-nex/Database/Distlogos/slax.png -- 19.49kb -> 19.18kb (1.59%) /I-Nex/i-nex/Database/Distlogos/linux_mint_KDE_BIG_sticker.png -- 20.09kb -> 19.78kb (1.57%) /I-Nex/i-nex/Data/GPU_LOGO/ati.png -- 14.53kb -> 14.35kb (1.2%) /I-Nex/i-nex/i-nex.png -- 3.12kb -> 3.09kb (1.03%) /I-Nex/i-nex/logo/i-nex.png -- 3.12kb -> 3.09kb (1.03%) /I-Nex/i-nex/Data/GPU_LOGO/vmware.png -- 16.77kb -> 16.67kb (0.63%) /pixmaps/i-nex-32.png -- 1.81kb -> 1.81kb (0.32%) /I-Nex/i-nex/Data/SATA/SATA.jpg -- 98.11kb -> 98.11kb (0%) /I-Nex/i-nex/Data/SATA/SATA2.jpg -- 110.87kb -> 110.87kb (0%) /I-Nex/i-nex/Data/SATA/SATA3.jpg -- 111.27kb -> 111.27kb (0%) /I-Nex/i-nex/Data/SATA/SATA1.jpg -- 112.10kb -> 112.09kb (0%) Signed-off-by: ImgBotApp <[email protected]>
[ImgBot] Optimize images
Several files in the repository are in need of an update to conform to current standards * .bzrignore and .gitignore referenced old paths & lacked pro forma entries for common IDEs * acinclude.m4 and configure.ac needed syntax fixes from deprecated styles to the current specification * README.md had broken links and accumulated cruft * .startup did not reference the most recent tagged release This commit contains the corrections for the above-listed issues Signed-off-by: Peter J. Mello <[email protected]>
The i-nex package as configured fails to build on Ubuntu 20.04 LTS "Focal Fossa" and does not build "lintian clean" on older versions. This commit updates the entirety of the Debian package configuration and brings it into compliance with the current Debian Standards Version, v4.5.0.2. The debhelper compatibility level is bumped to 12, trading the ability to build on Xenial for a package that should build successfully for no less than the next four Ubuntu releases and Debian Bullseye. Signed-off-by: Peter J. Mello <[email protected]>
The syntax of the Makefiles, notably the $(INSTALL) variable, was causing build failures when paired with the latest version of autotools. Also, the project metadata as defined by the FreeDesktop Desktop, Menu, and Metainfo Specifications was incorrectly named and, in places, incomplete. * The .desktop and .metainfo.xml files were renamed according to the reverse DNS rubric, as was the project ID referenced therein. This provides the unique identifier required by those specs. * i-nex-library.desktop was abandoned in favor of an Action supplied now by the main .desktop file. * Where needed, the $(INSTALL) variable in the several Makefiles was replaced with an explicit invocation of the `install` binary with parameters cogent to each individual operation. Signed-off-by: Peter J. Mello <[email protected]>
Signed-off-by: Peter J. Mello <[email protected]>
The dependency on libcpuid14 constrains builds for any architectures but amd64 and i386. Also, the gbp.conf file had a [git-dch] section that should've been '[dch]'. Finally, some standard FreeDesktop icon sizes were absent. * Declare the architectures for the binary package in debian/control as 'any-amd64 any-i386' * Add .png files corresponding to missing icon sizes in pixmaps/ and add them to the install and uninstall rules in the corresponding Makefile * Correct gbp.conf syntax and add several useful sections with optimal keys and values Signed-off-by: Peter J. Mello <[email protected]>
The Finfosys.class file defines a subroutine for counting the number of installed packages. For systems using `dpkg` it used grep + wc to manually parse internal dpkg database files. This is ill-advised as the dpkg API is constantly evolving and the calculation can be easily replaced with the `dpkg --get-selections` command, providing an identical result but by using a stable API call. This resolves the final lintian warning for the package, "W: i-nex: uses-dpkg-database-directly usr/bin/i-nex.gambas". Also, several source files misspelled the word 'needed' as 'nedded' and the .png icon files from the preceding commit were optimized using optipng. Signed-off-by: Peter J. Mello <[email protected]>
|
@RogueScholar |
RogueScholar
force-pushed
the
debian
branch
3 times, most recently
from
023929a to
651306d
Compare
Signed-off-by: Peter J. Mello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the source package recipe for the daily PPA was failing to build for Focal and Groovy, and what started out as a cursory tweaking of the debian/control file to solve that ended up unravelling into the monstrosity you now have before you. I tried to cover most of it in the commit messages, but feel free to ask questions as needed.
Also included is an optimization of all the .png and .svg files in the repository courtesy of ImgBot. I hadn't intended to include those as part of this PR but the amount of time involved in crafting the changes caused me to miss the grace period before the bot's initial run. I do think it's a beneficial change to the package in the long run so I left them in.
I hope this is received in the spirit of helpfulness in which it was created; I had no intention of stepping on any toes when I started. The fact that there are a lot of changes here felt like a reasonable solution to a lot of minor errata that had been accumulating over time and, overall, a better time investment than aiming for minimal disruption.
Warmly,
Peter