Remove autofocus option

i-like-robots · Nov 30, 2017 · 267beba · 267beba
1 parent afd26a1
commit 267beba
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 23 deletions.
diff --git a/README.md b/README.md
@@ -70,7 +70,6 @@ React.render(<App />, document.getElementById('app'))
 - [`tags`](#tags-optional)
 - [`suggestions`](#suggestions-optional)
 - [`placeholder`](#placeholder-optional)
-- [`autofocus`](#autofocus-optional)
 - [`autoresize`](#autoresize-optional)
 - [`delimiters`](#delimiters-optional)
 - [`delimiterChars`](#delimitersChars-optional)
@@ -113,10 +112,6 @@ const suggestions = [
 
 The placeholder string shown for the input. Default: `'Add new tag'`.
 
-#### autofocus (optional)
-
-Boolean parameter to control whether the text-input should be autofocused on mount. Default: `true`.
-
 #### autoresize (optional)
 
 Boolean parameter to control whether the text-input should be automatically resized to fit its value. Default: `true`.

diff --git a/lib/Input.js b/lib/Input.js
@@ -30,10 +30,6 @@ class Input extends React.Component {
       this.copyInputStyles()
       this.updateInputWidth()
     }
-
-    if (this.props.autofocus) {
-      this.input.focus()
-    }
   }
 
   componentDidUpdate (prevProps) {

diff --git a/lib/ReactTags.js b/lib/ReactTags.js
@@ -178,7 +178,6 @@ class ReactTags extends React.Component {
           <Input {...this.state}
             ref={(c) => { this.input = c }}
             listboxId={listboxId}
-            autofocus={this.props.autofocus}
             autoresize={this.props.autoresize}
             expandable={expandable}
             placeholder={this.props.placeholder} />
@@ -199,7 +198,6 @@ ReactTags.defaultProps = {
   tags: [],
   placeholder: 'Add new tag',
   suggestions: [],
-  autofocus: true,
   autoresize: true,
   delimiters: [KEYS.TAB, KEYS.ENTER],
   delimiterChars: [],
@@ -214,7 +212,6 @@ ReactTags.propTypes = {
   tags: PropTypes.arrayOf(PropTypes.object),
   placeholder: PropTypes.string,
   suggestions: PropTypes.arrayOf(PropTypes.object),
-  autofocus: PropTypes.bool,
   autoresize: PropTypes.bool,
   delimiters: PropTypes.arrayOf(PropTypes.number),
   delimiterChars: PropTypes.arrayOf(PropTypes.string),

diff --git a/spec/ReactTags.spec.js b/spec/ReactTags.spec.js
@@ -50,6 +50,8 @@ function $$ (selector) {
 }
 
 function type (value) {
+  $('input').focus()
+
   value.split('').forEach((char) => {
     key(char)
     $('input').value += char
@@ -94,16 +96,6 @@ describe('React Tags', () => {
       expect($('input').placeholder).toEqual('Please enter a tag')
     })
 
-    it('autofocuses on the input', () => {
-      createInstance({ autofocus: true })
-      expect(document.activeElement).toEqual($('input'))
-    })
-
-    it('does not autofocus on the input', () => {
-      createInstance({ autofocus: false })
-      expect(document.activeElement).not.toEqual($('input'))
-    })
-
     it('updates state when suggestions list is expanded', () => {
       createInstance()
 
@@ -131,7 +123,7 @@ describe('React Tags', () => {
     })
 
     it('calls focus and blur callbacks when provided', () => {
-      createInstance({ autofocus: false })
+      createInstance()
 
       TestUtils.Simulate.focus($('input'))
       sinon.assert.calledOnce(props.handleFocus)