COMMENTS - Empty PR #1256

JLoweAI · 2024-12-13T14:12:38Z

I created an empty branch and look to merge feature/remove-search into it to allow me to comment across the whole repo

Co-authored-by: George Burton <[email protected]>

Footnote citations

fix ingest error due to metadata size exceed max size

Feature/streaming with citations

…1130) * diabled gadget tests whilst we are actively working on them * reverted change * formatting

Bumps the pip group with 1 update in the /django_app directory: [werkzeug](https://github.com/pallets/werkzeug). Bumps the pip group with 1 update in the /redbox-core directory: [werkzeug](https://github.com/pallets/werkzeug). Bumps the pip group with 1 update in the / directory: [werkzeug](https://github.com/pallets/werkzeug). Updates `werkzeug` from 3.0.4 to 3.0.6 - [Release notes](https://github.com/pallets/werkzeug/releases) - [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst) - [Commits](pallets/werkzeug@3.0.4...3.0.6) Updates `werkzeug` from 3.0.4 to 3.0.6 - [Release notes](https://github.com/pallets/werkzeug/releases) - [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst) - [Commits](pallets/werkzeug@3.0.4...3.0.6) Updates `werkzeug` from 3.0.4 to 3.0.6 - [Release notes](https://github.com/pallets/werkzeug/releases) - [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst) - [Commits](pallets/werkzeug@3.0.4...3.0.6) --- updated-dependencies: - dependency-name: werkzeug dependency-type: indirect dependency-group: pip - dependency-name: werkzeug dependency-type: indirect dependency-group: pip - dependency-name: werkzeug dependency-type: indirect dependency-group: pip ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…un_sync to Redbox app for testing

Fixed passing citations through in agentic search

* restored doc name * replaced more original_file_name

…#1138) Co-authored-by: gecBurton <[email protected]>

…t parser

Calculating tokens from raw LLM response

* unique-citation uris * removed unused arg

remove ecr configuration

* Allow AWS OpenSearch IAM Permissions * Add OpenSearch Permissions

Removed gadget

Co-authored-by: Saisakul Chernbumroong <[email protected]>

* added csr and ecs for lit-ssr * Update infrastructure/aws/ecs.tf * added lit-ssr to Makefile * ecs is working * added service discovery * Add /health endpoint to lit-ssr * updated tf to match lit-ssr health endpoint * using correct port for LIT_SSR --------- Co-authored-by: Kevin Etchells <[email protected]>

JLoweAI · 2024-12-13T14:20:39Z

redbox-core/redbox/models/chain.py

+    chat_map_question_prompt: str = prompts.CHAT_MAP_QUESTION_PROMPT
+    reduce_system_prompt: str = prompts.REDUCE_SYSTEM_PROMPT
+
+    # Elasticsearch RAG and boost values


These can go?

JLoweAI · 2024-12-13T14:21:09Z

redbox-core/redbox/models/chain.py

+
+    # Task Prompt Fragments
+
+    chat_system_prompt: str = prompts.CHAT_SYSTEM_PROMPT


Do we just need one system prompt now?

JLoweAI · 2024-12-13T14:25:42Z

redbox-core/redbox/models/chain.py

+
+class RedboxState(BaseModel):
+    request: RedboxQuery
+    documents: Annotated[DocumentState, document_reducer] = DocumentState()


Are we still going to attatch documents to the state like this? Or have it be something that is more linked to the chat history?

JLoweAI · 2024-12-13T14:25:48Z

redbox-core/redbox/models/chain.py

+    documents: Annotated[DocumentState, document_reducer] = DocumentState()
+    route_name: str | None = None
+    metadata: Annotated[RequestMetadata | None, metadata_reducer] = None
+    citations: list[Citation] | None = None


JLoweAI · 2024-12-13T14:28:34Z

redbox-core/redbox/graph/nodes/processes.py

+    return _merge
+
+
+def build_stuff_pattern(


I am guessing this and the chat pattern will be the only ones we need?

JLoweAI · 2024-12-13T14:29:03Z

redbox-core/redbox/graph/nodes/processes.py

+    prompt_set: PromptSet,
+    output_parser: Runnable = None,
+    format_instructions: str | None = None,
+    tools: list[StructuredTool] | None = None,


Remove tools?

JLoweAI · 2024-12-13T14:35:41Z

django_app/redbox_app/redbox_core/models.py

+    stuff_chunk_context_ratio = models.FloatField(null=True, blank=True)
+    recursion_limit = models.PositiveIntegerField(null=True, blank=True)
+
+    chat_system_prompt = models.TextField(null=True, blank=True)


Am I right in thinking this is all needed because it was weirdly picking up empty strings and using them for the prompts?

I wonder if this is something we could improve while refactoring? Especially as we are slimming down the number of prompts.

JLoweAI · 2024-12-13T14:35:50Z

django_app/redbox_app/redbox_core/models.py

+    chat_map_question_prompt = models.TextField(null=True, blank=True)
+    reduce_system_prompt = models.TextField(null=True, blank=True)
+
+    # Elsticsearch RAG and boost values


JLoweAI · 2024-12-13T14:42:08Z

redbox-core/redbox/chains/ingest.py

+        document_loader(document_loader=loader, s3_client=s3_client, env=env)
+        | RunnableLambda(list)
+        | log_chunks
+        | RunnableLambda(partial(vectorstore.add_documents, create_index_if_not_exists=False))  # type: ignore[arg-type]


What does this look like without the vector store?

JLoweAI · 2024-12-13T14:42:36Z

redbox-core/redbox/loader/ingester.py

+def _ingest_file(file_name: str, es_index_name: str = alias):
+    logging.info("Ingesting file: %s", file_name)
+
+    es = env.elasticsearch_client()


What does this look like without elasticsearch?

JLoweAI · 2024-12-13T14:44:03Z

redbox-core/redbox/api/callbacks.py

+        """Run when chain errors."""
+        self.logger.error("Chain error: %s", error)
+
+    def on_text(self, text: str, **kwargs: Any) -> None:  # noqa:ARG002


Is this where message logging happens?

saisakul and others added 30 commits October 24, 2024 14:15

make explicit None is allowed

b7ec478

Co-authored-by: George Burton <[email protected]>

chore/added migrations and test (#1129)

c6be647

Removed debugging exception handling

bfc98f2

Addressing review comments

7e79a15

tighten codes

5ba62bc

Merge pull request #1118 from i-dot-ai/feature/citation_prompt

2802ad7

Footnote citations

update max_size to half

f87cc03

Merge pull request #1126 from i-dot-ai/fix_bugs/metadata_loader

e502b2b

fix ingest error due to metadata size exceed max size

Merge pull request #1128 from i-dot-ai/feature/streaming-with-citations

efbd5c8

Feature/streaming with citations

bugfix/disabled gadget tests whilst we are actively working on them (#…

0dd1f4d

…1130) * diabled gadget tests whilst we are actively working on them * reverted change * formatting

Add text_in_answer to Citation django model

7a69b5a

always init before executing terraform

74bfb25

handle missing backend config

58507f5

Update settings.py (#1131)

dc352eb

Fixed passing citations through in agentic search. Added debuggable r…

95d3516

…un_sync to Redbox app for testing

Ruff

cec9768

Handling non compliant format in StreamingJsonOutputParser

2fca752

Feature/rationalise file name (#1127)

89e704f

Merge branch 'main' into bugfix/restore-citation-passing

584394a

Merge pull request #1135 from i-dot-ai/bugfix/restore-citation-passing

d945578

Fixed passing citations through in agentic search

bugfix/restored doc name (#1136)

c157398

* restored doc name * replaced more original_file_name

Using filename passed from django app as uri in elastic model (#1139)

036bae8

renamed original_file_name -> file_name (#1137)

6391639

Feature/add govuk search (#1117)

ebb45e4

Storing text in answer in django model citations for use in footnotes (…

917710b

…#1138) Co-authored-by: gecBurton <[email protected]>

Calculating tokens from raw LLM response even when using custom outpu…

59e97eb

…t parser

Ruff

2085d03

Merge pull request #1140 from i-dot-ai/feature/token-counting-in-gadget

7d2b4aa

Calculating tokens from raw LLM response

feature/unique-citation uris (#1141)

825ce1b

* unique-citation uris * removed unused arg

RyanWhite25 and others added 19 commits December 3, 2024 11:10

remove universal submodule

a1d6f36

Merge pull request #1243 from i-dot-ai/noticket/rem-universal

3b20d70

remove ecr configuration

Allow AWS OpenSearch IAM Permissions (#1245)

ed739f3

* Allow AWS OpenSearch IAM Permissions * Add OpenSearch Permissions

Improve display of code in messages

982259c

Removed gadget

d88bb93

Removing unnecessary settings and functions only used by agentic search

c4535f0

Removed gadget integration test cases

5e19b20

Merge pull request #1248 from i-dot-ai/feature/remove-gadget

b6746ec

Removed gadget

removed search subgraph

df8c2ba

remove parametrized retiever from get_root_graph

c290f30

removed parametrized retirver

6115914

remove self route

d03ccd9

removed search keyword

ed10d35

removed some unused functions

c10e841

graphs updated

1043431

Build new document-upload component

71d542a

add platform for unstructured (#1230)

2f87a7f

Co-authored-by: Saisakul Chernbumroong <[email protected]>

Merge branch 'feature/v1.0.0' into feature/remove-search

f244a64

JLoweAI commented Dec 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

COMMENTS - Empty PR #1256

COMMENTS - Empty PR #1256

JLoweAI commented Dec 13, 2024

JLoweAI Dec 13, 2024

JLoweAI Dec 13, 2024

JLoweAI Dec 13, 2024

JLoweAI Dec 13, 2024

JLoweAI Dec 13, 2024

JLoweAI Dec 13, 2024

JLoweAI Dec 13, 2024

JLoweAI Dec 13, 2024

JLoweAI Dec 13, 2024

JLoweAI Dec 13, 2024

JLoweAI Dec 13, 2024


		# Task Prompt Fragments

		chat_system_prompt: str = prompts.CHAT_SYSTEM_PROMPT

COMMENTS - Empty PR #1256

Are you sure you want to change the base?

COMMENTS - Empty PR #1256

Conversation

JLoweAI commented Dec 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment