Build new homepage and menu structure in prototype #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| { | ||
| href: "/how-it-works", | ||
| text: "Data format" |
There was a problem hiding this comment.
Suggested change
| text: "Data format" | |
| text: "Data schema" |
There was a problem hiding this comment.
That's updated now, @duncanjbrown
prototype/app/views/index.html
Outdated
| <div class="govuk-grid-row"> | ||
| <div class="govuk-grid-column-two-thirds-from-desktop"> | ||
| <h1 class="x-govuk-masthead__title"> | ||
| Take the responses to your consultation and use machine learning to create themes |
There was a problem hiding this comment.
I'd like to finish the conversation on copy (in the GDoc) before we go in on this!
There was a problem hiding this comment.
I can see it's now updated in the doc. I've just push a commit to change it to:
"Use machine learning to help you understand consultation responses"
(this definitely reads better to me)
Update share icon and hide icons from screen-readers Add feedback link to Prototype Update homepage title Change "Data format" to "Data schema"
KevinEtchells
force-pushed
the
feature/new-home-page
branch
from
1570bc6 to
dd70db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is the first in a series of updates for the new homepage content. This covers the homepage and the menu structure.
Currently the other menu items are broken links. I think this is okay because:
Changes proposed in this pull request
Updating the homepage to this:
Moving the prototype page to
/prototype(there is also a footer link to this)Guidance to review
Link to JIRA ticket
https://technologyprogramme.atlassian.net/jira/software/projects/CON/boards/418?selectedIssue=CON-81