Feature/more models #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanjbrown
reviewed
Mar 5, 2024
nmenezes0
force-pushed
the
feature/more_models
branch
from
62a66ef to
47db3b0
Compare
duncanjbrown
approved these changes
Mar 5, 2024
duncanjbrown
approved these changes
Mar 5, 2024
duncanjbrown
reviewed
Mar 6, 2024
duncanjbrown
reviewed
Mar 6, 2024
duncanjbrown
reviewed
Mar 6, 2024
| @@ -1,19 +1,85 @@ | |||
| # Generated by Django 5.0.2 on 2024-02-29 14:08 | |||
| # Generated by Django 5.0.3 on 2024-03-05 16:48 | |||
There was a problem hiding this comment.
Having tried to apply this locally I needed to clear my db first — I think fine to have multiple migrations!
duncanjbrown
reviewed
Mar 6, 2024
duncanjbrown
reviewed
Mar 6, 2024
duncanjbrown
reviewed
Mar 6, 2024
duncanjbrown
reviewed
Mar 6, 2024
duncanjbrown
reviewed
Mar 6, 2024
duncanjbrown
reviewed
Mar 6, 2024
1 task
duncanjbrown
reviewed
Mar 7, 2024
duncanjbrown
reviewed
Mar 7, 2024
nmenezes0
force-pushed
the
feature/more_models
branch
from
3f0e04e to
16c9255
Compare
duncanjbrown
reviewed
Mar 8, 2024
nmenezes0
force-pushed
the
feature/more_models
branch
from
de81d1f to
28b0bee
Compare
|
Closing as covered in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adding basic models to the Django app for consultations.
Changes proposed in this pull request
Add more models - roughly following the diagram here: https://excalidraw.com/.
Some of the fields will need refining, but I think this is fine as a first-pass (to allow us to progress with other tickets).
Guidance to review
Run the app - does it work ok?
Do the models look sensible based on the diagram?
Link to JIRA ticket
https://technologyprogramme.atlassian.net/browse/CON-24 - doesn't do everything, but part of the Django app set-up.
Things to check
.env.exampleand.env.testfiles in the repo - N/A