Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/frontend prototype #6

Merged
merged 11 commits into from
Mar 5, 2024
Merged

Conversation

KevinEtchells
Copy link
Contributor

A random assortment of updates to the Frontend Prototype. Including:

Adding bar-chart-style indicators to the Prevalent themes table on the Question Summary page

image

Changing the questions table on the home page as per the discussion on Slack

image

Adding all filters to the question-responses page

Keyword filtering is now working. The other filters will be working once I've plugged in some proper data
image

Tidying up doughnut charts

Using accessible colours and adding labels to the larger chart
image

Adding responses to the Respondent page

image

@nmenezes0
Copy link
Contributor

This error:

197              },
198              {
199                value: "organisation",
200                text: "Organisation"
201              }
202            ]
203          }) }}
204  
205          {{ govukButton({
206            text: "Apply filters",
207            classes: "govuk-!-margin-bottom-1"
208          }) }}
209        </form>
210      </div>

When I click on "Explore responses"

'#005abb',
'#a23138',
'#cc5a13'
backgroundColor: [ // based on https://analysisfunction.civilservice.gov.uk/policy-store/data-visualisation-colours-in-charts/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@KevinEtchells KevinEtchells merged commit 95614db into main Mar 5, 2024
1 check passed
<td class="govuk-table__cell">{{question}}</td>
<td class="govuk-table__cell">
<a href="/respondent">View respondent</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we feel about "respondent" vs, say "response" here? My instinct is that the response is the thing we'd view, and the respondent would be a feature of the response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants