Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/40 question summary page #14

Merged
merged 12 commits into from
Mar 20, 2024
Merged

Conversation

nmenezes0
Copy link
Contributor

@nmenezes0 nmenezes0 commented Mar 12, 2024

Context

Add a very basic question summary page (content and styling to be improved!).

Changes proposed in this pull request

Add a very basic question summary page - text of the question and list of themes.

This involves:

  • Adding a Theme factory
  • Adding a new page for the question summary

Additionally, changes in the migrations file are just from running ruff (code checks added in a separate PR).

image

TODO in a separate PR - styling.

Guidance to review

  • Generate some data by running the management command: poetry run python manage.py generate_dummy_data.
  • Go to the URL: consultation/<str:consultation_slug>/section/<str:section_slug>/question-summary/<str:question_slug>/ - and check question summary and some themes display (there may be duplicates, haven't gone as far as getting counts).
    (Get slugs from the database - pick a question and get the slug for that, the related section, and the consultation related to that section.)
  • General code review.

Link to JIRA ticket

https://technologyprogramme.atlassian.net/browse/CON-40

Things to check

  • I have added any new ENV vars in all deployed environments and updated the .env.example and .env.test files in the repo - N/A

@nmenezes0 nmenezes0 marked this pull request as draft March 12, 2024 15:54
@nmenezes0 nmenezes0 marked this pull request as ready for review March 13, 2024 15:57
@nmenezes0 nmenezes0 changed the title Draft: Feature/40 question summary page Feature/40 question summary page Mar 13, 2024
@duncanjbrown duncanjbrown force-pushed the feature/40-question-summary-page branch from 76ada79 to 6845a5a Compare March 13, 2024 17:04
@nmenezes0 nmenezes0 force-pushed the feature/40-question-summary-page branch from 91deda6 to 74bd3db Compare March 15, 2024 14:42
@nmenezes0 nmenezes0 requested a review from duncanjbrown March 15, 2024 14:42
@nmenezes0 nmenezes0 force-pushed the feature/40-question-summary-page branch from 4bc37a5 to de6f1ad Compare March 15, 2024 16:18
@nmenezes0 nmenezes0 marked this pull request as draft March 15, 2024 16:31
@nmenezes0 nmenezes0 force-pushed the feature/40-question-summary-page branch from 3174a4f to 9f2f9e7 Compare March 15, 2024 22:47
@nmenezes0 nmenezes0 marked this pull request as ready for review March 15, 2024 22:52
@nmenezes0
Copy link
Contributor Author

Changes now made - updated URL and name of view, deleted old question page (was there as a test), added a factory to create Answers, Themes etc for test.

Copy link
Contributor

@duncanjbrown duncanjbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! few comments inline

.github/workflows/test.yml Outdated Show resolved Hide resolved
consultation_analyser/consultations/views.py Show resolved Hide resolved
tests/factories.py Outdated Show resolved Hide resolved
consultation_analyser/consultations/urls.py Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@nmenezes0 nmenezes0 force-pushed the feature/40-question-summary-page branch 3 times, most recently from 89c40f8 to 42af46b Compare March 18, 2024 14:31
@nmenezes0 nmenezes0 requested a review from duncanjbrown March 18, 2024 17:16
Copy link
Contributor

@duncanjbrown duncanjbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks vg! pls could you rebase and tidy commits?

consultation_analyser/hosting_environment.py Show resolved Hide resolved
@nmenezes0 nmenezes0 force-pushed the feature/40-question-summary-page branch 2 times, most recently from 7d3585a to d44c001 Compare March 19, 2024 08:16
@nmenezes0 nmenezes0 requested a review from duncanjbrown March 19, 2024 11:12
@nmenezes0 nmenezes0 force-pushed the feature/40-question-summary-page branch from d44c001 to bd14ab7 Compare March 20, 2024 16:47
@nmenezes0 nmenezes0 merged commit 229096b into main Mar 20, 2024
2 checks passed
@nmenezes0 nmenezes0 deleted the feature/40-question-summary-page branch March 20, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants