-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/40 question summary page #14
Conversation
76ada79
to
6845a5a
Compare
91deda6
to
74bd3db
Compare
4bc37a5
to
de6f1ad
Compare
3174a4f
to
9f2f9e7
Compare
Changes now made - updated URL and name of view, deleted old question page (was there as a test), added a factory to create Answers, Themes etc for test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! few comments inline
89c40f8
to
42af46b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks vg! pls could you rebase and tidy commits?
7d3585a
to
d44c001
Compare
d44c001
to
bd14ab7
Compare
Context
Add a very basic question summary page (content and styling to be improved!).
Changes proposed in this pull request
Add a very basic question summary page - text of the question and list of themes.
This involves:
Additionally, changes in the migrations file are just from running ruff (code checks added in a separate PR).
TODO in a separate PR - styling.
Guidance to review
poetry run python manage.py generate_dummy_data
.consultation/<str:consultation_slug>/section/<str:section_slug>/question-summary/<str:question_slug>/
- and check question summary and some themes display (there may be duplicates, haven't gone as far as getting counts).(Get slugs from the database - pick a question and get the slug for that, the related section, and the consultation related to that section.)
Link to JIRA ticket
https://technologyprogramme.atlassian.net/browse/CON-40
Things to check
.env.example
and.env.test
files in the repo - N/A