Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/one year blog #71

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Feature/one year blog #71

wants to merge 9 commits into from

Conversation

KevinEtchells
Copy link
Collaborator

Context

Building a couple of components needed for the one year blog. Also allowing for these components to be added to future blogs by integrating with the CMS.

Changes proposed in this pull request

  • Build this infographic in HTML + CSS (because just inserting it as an image wouldn't meet our accessibility standards)
  • Build a new carousel component:
  • Add these as components to the CMS

  • Add to the CMS preview. As part of this I've added Lit to the project to make this much easier. I'll gradually add Lit components as we continue to integrate the new CMS.

Guidance to review

  • Check the changes look sensible
  • I can set up a demo blog post so you can see these components live if that'd be useful

Things to check

  • Styling has not broken
  • Content changes have been reviewed and approved
  • No sensitive information about the team or our upcoming work has been included

@@ -0,0 +1,2 @@
[*.mjs]
max_line_length = 999
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this looks a lot, but it's mainly to prevent wrapping inline SVG paths. We can still be sensible with line-lengths elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant