Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated magento-coding-standard for mimimum requirement magento 2.4.6 #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rakibabu
Copy link

No description provided.

@Vinai
Copy link
Contributor

Vinai commented Mar 16, 2023

Thanks for the PR!
Could you please summarize the differences and why it us better now?

@rakibabu
Copy link
Author

Hi Vinai,

This change is only in the composer.json to not lock the magento/magento-coding-standard version to 25. Magento 2.4.6 uses version 31.

@Vinai
Copy link
Contributor

Vinai commented Mar 17, 2023

Hi @rakibabu - thanks, that much is clear.
I was asking about the differences between v25 and v31. From my side there is no necessity to have the Hyvä coding standard follow the Magento one during upgrades.

Rather than blindly include any changes that Adobe makes, I would much rather choose if the changes are actually an improvement, and also check if they cause existing Hyvä code to no longer pass.

If you could summarize the changes between v25 and v31 of the Magento coding standard that would be helpful.
Otherwise I'll check it out when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants