Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: move to sdbus-cpp2 #278

Merged
merged 4 commits into from
Oct 22, 2024
Merged

core: move to sdbus-cpp2 #278

merged 4 commits into from
Oct 22, 2024

Conversation

vaxerski
Copy link
Member

@vaxerski vaxerski commented Oct 22, 2024

Works, needs testing. Screencopy seems to be doin good

@fufexan ci

@VirtCode
Copy link

Working fine for me too so far, tested screencopy with OBS and Vesktop. Is there something other than screencopy that would need testing?

@vaxerski
Copy link
Member Author

color picking and global shortcuts, ideally

@Agent00Ming
Copy link

Any clients known to use the GlobalShortcuts portal? Screenshots and color picking seem to work fine.

@vaxerski
Copy link
Member Author

not that I know of. I used some random mumble fork back when designing this

@VirtCode
Copy link

VirtCode commented Oct 22, 2024

Can confirm that the Screenshot portal with PickColor is working fine.

I also tested GlobalShortcuts (managed to find one of the rare programs that actually have support for it) and they also work as expected (as far as I can tell). So I think this is good to go.

For future reference, here's how I tested the GlobalShortcuts:
I used gpu-screen-recorder-gtk-git but had to patch out an exception for hyprland which was related to an issue which has by now been fixed.

  1. install gpu-screen-recorder-git from the AUR
  2. clone https://repo.dec05eba.com/gpu-screen-recorder-gtk (webpage)
  3. patch out the hyprland exception with the following patch
diff --git a/src/main.cpp b/src/main.cpp
index b8c0e71..0d9253e 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -4006,7 +4006,7 @@ static void activate(GtkApplication *app, gpointer) {
         // instead of having a "register hotkeys" button. This needed because Hyprland doesn't remember registered hotkeys after
         // the desktop portal is restarted (when the computer is restarted for example).

-        if(wayland_compositor == WaylandCompositor::HYPRLAND) {
+        if(wayland_compositor == WaylandCompositor::HYPRLAND && false) {
             const char *hotkeys_not_supported_text = "Global hotkeys have been disabled on your system because of a Hyprland bug.\nUse X11 or KDE Plasma on Wayland if you want to use hotkeys.";
             gtk_label_set_text(GTK_LABEL(recording_hotkeys_not_supported_label), hotkeys_not_supported_text);
             gtk_label_set_text(GTK_LABEL(replay_hotkeys_not_supported_label), hotkeys_not_supported_text);
  1. build and run the program
  2. select "Record" and click "Change hotkeys"
  3. (see shortcuts with hyprctl globalshortcuts)
  4. bind to one of the shortcuts hyprctl keyword bind SUPER, Z, global, :gpu_screen_recorder_start_stop_recording
  5. test

@vaxerski
Copy link
Member Author

cool, thanks!

@vaxerski vaxerski merged commit 5c72a7f into master Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants