-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: move to sdbus-cpp2 #278
Conversation
Working fine for me too so far, tested screencopy with OBS and Vesktop. Is there something other than screencopy that would need testing? |
color picking and global shortcuts, ideally |
Any clients known to use the GlobalShortcuts portal? Screenshots and color picking seem to work fine. |
not that I know of. I used some random mumble fork back when designing this |
Can confirm that the Screenshot portal with PickColor is working fine. I also tested GlobalShortcuts (managed to find one of the rare programs that actually have support for it) and they also work as expected (as far as I can tell). So I think this is good to go. For future reference, here's how I tested the GlobalShortcuts:
diff --git a/src/main.cpp b/src/main.cpp
index b8c0e71..0d9253e 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -4006,7 +4006,7 @@ static void activate(GtkApplication *app, gpointer) {
// instead of having a "register hotkeys" button. This needed because Hyprland doesn't remember registered hotkeys after
// the desktop portal is restarted (when the computer is restarted for example).
- if(wayland_compositor == WaylandCompositor::HYPRLAND) {
+ if(wayland_compositor == WaylandCompositor::HYPRLAND && false) {
const char *hotkeys_not_supported_text = "Global hotkeys have been disabled on your system because of a Hyprland bug.\nUse X11 or KDE Plasma on Wayland if you want to use hotkeys.";
gtk_label_set_text(GTK_LABEL(recording_hotkeys_not_supported_label), hotkeys_not_supported_text);
gtk_label_set_text(GTK_LABEL(replay_hotkeys_not_supported_label), hotkeys_not_supported_text);
|
cool, thanks! |
Works, needs testing. Screencopy seems to be doin good
@fufexan ci