Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

animation: add CAnimationConfigTree #29

Merged
merged 1 commit into from
Jan 2, 2025
Merged

animation: add CAnimationConfigTree #29

merged 1 commit into from
Jan 2, 2025

Conversation

PaideiaDilemma
Copy link
Contributor

No description provided.

@PaideiaDilemma PaideiaDilemma force-pushed the animation branch 2 times, most recently from 92f1cb7 to ce1c436 Compare January 1, 2025 17:15
vaxerski
vaxerski approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm. config moving shouldn't break ABI as its still in the same namespace.

Is this ready to merge?

@PaideiaDilemma
Copy link
Contributor Author

It's ready I think.
I also tested the implementation by using it in Hyprland. Should be good.

@vaxerski
Copy link
Member

vaxerski commented Jan 2, 2025

let's roll

@vaxerski vaxerski merged commit 6a26d08 into hyprwm:main Jan 2, 2025
4 checks passed
@PaideiaDilemma PaideiaDilemma deleted the animation branch January 2, 2025 14:11
@jbeich jbeich mentioned this pull request Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaideiaDilemma @vaxerski