Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: fix package and add devshell #5

Merged
merged 1 commit into from
Oct 15, 2024
Merged

nix: fix package and add devshell #5

merged 1 commit into from
Oct 15, 2024

Conversation

outfoxxed
Copy link
Member

Fixes nix package + adds dev environment

@outfoxxed
Copy link
Member Author

@fufexan I preserved the behavior, but generating compile_commands.json from the shell hook seems rather odd.

@outfoxxed
Copy link
Member Author

rebased on #8

Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @vaxerski for the cpp/qml side of things.

@fufexan
Copy link
Member

fufexan commented Oct 14, 2024

@fufexan I preserved the behavior, but generating compile_commands.json from the shell hook seems rather odd.

I don't assume many people use the devshell anyway, but I wanted to have it automatically done or else clangd would yell at me.

@vaxerski
Copy link
Member

cpp stuff is based on #8 and discussion is there

@outfoxxed
Copy link
Member Author

rebased on #8 again

@outfoxxed
Copy link
Member Author

*again

@outfoxxed
Copy link
Member Author

how

@vaxerski vaxerski requested a review from fufexan October 15, 2024 12:23
@fufexan fufexan merged commit 707a315 into hyprwm:main Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants