Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XDG_DATA_DIRS to query themes #58

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Use XDG_DATA_DIRS to query themes #58

merged 3 commits into from
Jul 30, 2024

Conversation

Libadoxon
Copy link
Contributor

Fixes 26. This also eliminates the need for a NixOs patch as it uses XDG_DATA_DIRS to link to all important directories. My C++ is also very bad so I hope I didn't screw anything up. It worked for me but other than that I didn't do any tests.

libhyprcursor/hyprcursor.cpp Outdated Show resolved Hide resolved
libhyprcursor/hyprcursor.cpp Outdated Show resolved Hide resolved
libhyprcursor/hyprcursor.cpp Outdated Show resolved Hide resolved
@Libadoxon Libadoxon requested a review from vaxerski July 30, 2024 13:46
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm also @fufexan for nix

libhyprcursor/hyprcursor.cpp Show resolved Hide resolved
Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@vaxerski vaxerski merged commit 5a95d85 into hyprwm:main Jul 30, 2024
1 check passed
@jbeich jbeich mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor theme should search in dirs specified by $XDG_DATA_DIRS if present
3 participants