Make hyprctl setcursor better (support XCursor themes, also give fail message) #6097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shit aint compilin doe |
|
|
|
sorry I skim over long ass descriptions havent caught that, mark it as draft if it depends on something and link the deps |
|
ummm, how do I make build work with hyprcursor-git or jus wait |
|
remind me later tomorrow if I forget to make a new hc release, then we bump the nix flake and wait for arc lonix |
|
reminder |
|
thanks! done. @fufexan can you bump the flake here? then we just wait for arc |
|
should be gtg now |
vaxerski
reviewed
May 25, 2024
ikalco
force-pushed
the
switch_to_xcursor_themes
branch
from
171072b to
6fe2c46
Compare
cdubthecoolcat
pushed a commit
to cdubthecoolcat/Hyprland
that referenced
this pull request
May 29, 2024
…sage) (hyprwm#6097) * add support for changing to X cursor themes * use new hyprcursor abi for options * remove unneeded struct
dedsm
pushed a commit
to dedsm/Hyprland
that referenced
this pull request
Jun 3, 2024
…sage) (hyprwm#6097) * add support for changing to X cursor themes * use new hyprcursor abi for options * remove unneeded struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
makes it so that hyprctl setcursor can be used to change cursor theme between Hyprcursor and Xcursor
also addresses these issues
setcursor doesn't apply immediately #4221, by removing this code
Hyprland/src/managers/CursorManager.cpp
Lines 269 to 270 in de9798f
hyrctl setcursor should throw error if cursor theme doesn't exist #5232, and adding this too
Hyprland/src/debug/HyprCtl.cpp
Lines 1066 to 1069 in deb7c4f
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
This PR also requires a change in hyprcursor, see hyprwm/hyprcursor#43
The git blame for these lines is for a bug fix, but I believe this was left over when CursorManager was later changed?
either way code should still work the same, just a little less efficient i guess
Hyprland/src/managers/CursorManager.cpp
Lines 269 to 270 in de9798f
Is it ready for merging, or does it need work?
No, I need to get hyprcursor PR merged first (hyprwm/hyprcursor#43)
tested on my machine